Fix updatedAt field and remove id field from services#25
Merged
Conversation
…ated methods - Added UpdatedAt field to ServiceInstance struct for tracking last update time. - Updated mockOrchestratorHandler methods to set UpdatedAt during service instance creation and retrieval. - Modified API adapter and orchestrator methods to handle UpdatedAt field appropriately. - Introduced GetUpdatedAt method in GenericServiceInstance to retrieve the last update time. - Ensured consistency across service instance management with the new UpdatedAt field.
teemow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve the tracking of service instance updates by adding an
UpdatedAtfield across the codebase. It also removes theIDfield from theServiceInstancestruct, simplifying the representation of service instances. Below is a summary of the most important changes grouped by theme.Improved tracking of service instance updates:
UpdatedAtfield to theServiceInstanceInfostruct ininternal/orchestrator/orchestrator.goto track the last update time of service instances.CreateServiceClassInstanceandserviceInstanceToInfomethods ininternal/orchestrator/orchestrator.goto populate theUpdatedAtfield appropriately. [1] [2]GetUpdatedAtmethod to theGenericServiceInstancestruct ininternal/services/instance.goto retrieve the last update time.convertToAPIServiceInstancemethod ininternal/orchestrator/api_adapter.goto include theUpdatedAtfield in API conversions.Simplification of service instance representation:
IDfield from theServiceInstancestruct ininternal/api/serviceinstance.goto simplify service instance representation.internal/api/orchestrator_test.goto remove references to theIDfield and ensure compatibility with the updatedServiceInstancestruct. [1] [2] [3]