Merged
Conversation
This simplifies the logging system by removing the dual-mode (CLI/TUI) architecture that was no longer in use: - Remove LogEntry struct, TUI channel, and mode switching logic - Simplify InitForCLI to directly set up the slog handler - Remove Initcommon function and TUI-related code paths - Update documentation to reflect CLI-only logging - Remove dead logToStderr function - Fix broken GoDoc list formatting in app/doc.go The logging system now has a cleaner, single-path implementation using Go's standard slog package.
The PR template referenced internal/tui/view/testdata/ which no longer exists after the TUI was removed from the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the logging system by removing the dual-mode (CLI/TUI) architecture that was no longer in use.
Changes
LogEntrystruct, TUI channel, and mode switching logic frompkg/loggingInitForCLIto directly set up the slog handlerInitcommonfunction and TUI-related code pathspkg/logging/doc.goandinternal/app/doc.goto reflect CLI-only logginglogToStderrfunction that was never calledinternal/app/doc.goBenefits
InitForCLIlogInternalFiles Changed
pkg/logging/logging.gopkg/logging/logging_test.gopkg/logging/doc.gointernal/app/bootstrap.gointernal/app/bootstrap_test.gointernal/app/config.gointernal/app/doc.go.github/pull_request_template.mdTest plan
go test ./pkg/logging/... ./internal/app/...)