Fix: Restore groups scope in DefaultOAuthCIMDScopes#518
Merged
Conversation
The groups scope was incorrectly removed in e983c81 as "Dex-specific". Groups are required for RBAC decisions in downstream services like mcp-kubernetes and are mapped for customers. Provider-level scope filtering in mcp-oauth (filterGoogleScopes, filterDexScopes) already handles provider differences correctly -- Google strips unsupported scopes, Dex keeps groups. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
groupstoDefaultOAuthCIMDScopes(openid profile email groups offline_access)groupsscope was incorrectly removed in Fix: OIDC scope handling for multi-provider compatibility #514 as "Dex-specific", but it is required for group-based RBAC in downstream services like mcp-kubernetes and is mapped for customersfilterGoogleScopesstrips unsupported scopes, Dex'sfilterDexScopeskeepsgroupsTest plan
Made with Cursor