Skip to content

chore(api): remove deprecated RegisterConfig/GetConfig aliases (#140)#618

Merged
QuentinBisson merged 4 commits into
mainfrom
chore-140-quick-wins
May 7, 2026
Merged

chore(api): remove deprecated RegisterConfig/GetConfig aliases (#140)#618
QuentinBisson merged 4 commits into
mainfrom
chore-140-quick-wins

Conversation

@QuentinBisson
Copy link
Copy Markdown
Contributor

Closes part of #140.

Two deprecated API wrappers (RegisterConfig, GetConfig) were already suppressed at every call site with //nolint:staticcheck. Removes the wrappers and the directives. Also adds the missing internal/template/doc.go so every package has its doc file.

Pure cleanup, no behavior change.

@QuentinBisson QuentinBisson marked this pull request as ready for review May 5, 2026 19:42
@QuentinBisson QuentinBisson requested a review from a team as a code owner May 5, 2026 19:42
@QuentinBisson QuentinBisson marked this pull request as draft May 5, 2026 20:28
@QuentinBisson QuentinBisson marked this pull request as ready for review May 5, 2026 20:45
@QuentinBisson
Copy link
Copy Markdown
Contributor Author

Self-review wrap-up — ready for an external pair of eyes.

Why this should merge: Pure cleanup, no behaviour change.

  • api.RegisterConfig and api.GetConfig were already suppressed at every call site with //nolint:staticcheck. Removing the wrappers eliminates the suppressions too.
  • Added the missing internal/template/doc.go so every package has its doc file.
  • All 4 call sites switched to RegisterConfigHandler / GetConfigHandler. CHANGELOG entry under ### Removed.

CI green; mergeable.

@paurosello paurosello force-pushed the chore-140-quick-wins branch from 990e413 to ab6b8d1 Compare May 7, 2026 15:37
Copy link
Copy Markdown
Contributor

@paurosello paurosello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mechanical cleanup, all 5 callers migrated to canonical *Handler names. Aligned with service-locator pattern in internal/api.

@QuentinBisson QuentinBisson enabled auto-merge (squash) May 7, 2026 22:12
@QuentinBisson QuentinBisson merged commit 1c7ff0b into main May 7, 2026
5 of 6 checks passed
@QuentinBisson QuentinBisson deleted the chore-140-quick-wins branch May 7, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants