Conversation
QuantumEnigmaa
requested review from
QuentinBisson,
mcharriere and
ubergesundheit
| @@ -0,0 +1,10 @@ | |||
| FROM gsoci.azurecr.io/giantswarm/alpine:3.20.3-giantswarm | |||
Contributor
There was a problem hiding this comment.
What's the use of those 2 from btw?
Contributor
Author
There was a problem hiding this comment.
It's because this is a multi-stage dockerfile.
The first FROM is needed to get the /etc/passwd and /etc/group files and pass it to the second stage which build from scratch and just adds these 2 files and the binary to the image.
QuentinBisson
approved these changes
Jul 24, 2025
Contributor
Author
|
The last commit is an attempt to fix the current issue encountered when trying to run a container from the image generated by the previous version of the Dockerfile: Building from But we'll have to update the base image that is currently |
Member
|
@QuantumEnigmaa @QuentinBisson same as in #94
|
teemow
force-pushed
the
add-dockerfile
branch
from
e20a4d8 to
07d6e4d
Compare
- Add Dockerfile using giantswarm alpine base image (same pattern as mcp-kubernetes) - Enable push-to-registries in CircleCI workflow
teemow
force-pushed
the
add-dockerfile
branch
from
07d6e4d to
be1880d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a Dockerfile for allowing muster to be deployed as an app in a cluster thanks to a follow-up PR that will add a Helm chart.
It also updates the circleci config so that muster is pushed to our image registries.
Testing
internal/tui/view/testdata/), new files have been generated/updated (e.g., by runninggo test ./internal/tui/view/... -update) and meticulously verified.Do the docs need to be updated?
Should this change be mentioned in the release notes?