fix: support multi-byte string encodings (GBK, UTF-8) in string helpers - #788
Open
gijzelaerr wants to merge 1 commit into
Open
fix: support multi-byte string encodings (GBK, UTF-8) in string helpers#788gijzelaerr wants to merge 1 commit into
gijzelaerr wants to merge 1 commit into
Conversation
…et_string Replace per-byte chr()/ord() conversion with proper bytes.decode()/str.encode() and add an `encoding` parameter (default "latin-1" for backward compatibility). This allows reading and writing multi-byte strings such as GBK-encoded Chinese text on S7-200 Smart and S7-300 PLCs. Closes #786 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chr()/ord()conversion with properbytes.decode()/str.encode()inget_fstring,get_string,set_fstring, andset_stringencodingparameter (default"latin-1"for backward compatibility) to all four functionsTest plan
TrÖt/TrĪtround-trip tests)Closes #786
🤖 Generated with Claude Code