chore(ci): use composer scripts, add cache and status badges (refs #117)#147
Merged
Conversation
- Use composer scripts (test, lint, analyse) in workflows so local and CI runs share the same definition. - Cache composer dependencies via actions/cache@v4 keyed on PHP version + Laravel matrix + composer.json hash. - Expand branch trigger filter to include chore/* and refactor/*. - Add Tests and Code Quality status badges to README. - Keep PHPStan as a soft check (continue-on-error) until the baseline ignores (#118) and external-class stubs (#145) land, after which this can be turned hard. Refs #117
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samenvatting
Eerste deel van #117 — bestaande GitHub Actions workflows verbeteren en consistent maken met de lokale workflow.
Wijzigingen
Workflows
composer test|lint|analysescripts gebruiken i.p.v. losse commands → lokale en CI runs hebben dezelfde definitieactions/cache@v4, gekoppeld aan PHP versie + Laravel matrix +composer.jsonhash → snellere CI builds na de eerste runchore/*enrefactor/*zodat alle conventionele branches CI triggerenREADME
PHPStan blijft soft
PHPStan staat nog op
continue-on-error: true. Reden: tot de PHPStan baseline-cleanup (#118) gemerged is, en de external-class stubs (#145) zijn opgelost, leveren level 0 runs opdevelop11 pre-existing errors. Hard-faillende CI zou alle PRs blokkeren.Volgvolgorde:
continue-on-error: trueweghaalt → hard failVerificatie
python3 -c "import yaml; yaml.safe_load(...)")Out of scope
main(handmatige stap voor repo-admin)Refs #117