About the GirCore1007 warning

[PlatinumLucario]

After updating to GirCore 0.8.0, I noticed a huge change.

It brought up a warning called GirCore1007, which tells me I need to do stuff very differently now, as explained in here.

I don't quite understand fully about how to properly change stuff like classes that rely on Adw.Window, such as this code:

using System;
using System.Runtime.InteropServices;
using Adw;
using Kermalis.VGMusicStudio.Core;

namespace Kermalis.VGMusicStudio.GTK4;

internal class Preferences : Window
{
    private Mixer.AudioBackend PlaybackBackend;

    private Gtk.CheckButton RadioButtonPortAudio { get; set; }
    private Gtk.CheckButton RadioButtonMiniAudio { get; set; }
    private Gtk.CheckButton RadioButtonNAudio { get; set; }

    internal Preferences()
    {
        New();

        Title = $"Preferences - {MainWindow.GetProgramName()}";
        FocusVisible = true;
        FocusOnClick = true;

        var header = HeaderBar.New();

        var labelAudioBackend = Gtk.Label.New("Audio Backend:");

        RadioButtonMiniAudio = Gtk.CheckButton.New();
        RadioButtonMiniAudio.Label = "MiniAudio";
        RadioButtonMiniAudio.OnNotify += OnNotify_MiniAudio;
        RadioButtonPortAudio = Gtk.CheckButton.New();
        RadioButtonPortAudio.Label = "PortAudio";
        RadioButtonPortAudio.OnNotify += OnNotify_PortAudio;
        RadioButtonNAudio = Gtk.CheckButton.New();
        RadioButtonNAudio.Label = "NAudio (Legacy, Deprecated, Windows Only)";
        if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
        {
            RadioButtonNAudio.Sensitive = true;
            RadioButtonNAudio.OnNotify += OnNotify_NAudio;
        }
        else
        {
            RadioButtonNAudio.Sensitive = false;
        }
        RadioButtonPortAudio.SetGroup(RadioButtonMiniAudio);
        RadioButtonPortAudio.SetGroup(RadioButtonNAudio);
        
        switch (Mixer.PlaybackBackend)
        {
            case Mixer.AudioBackend.MiniAudio:
                {
                    RadioButtonMiniAudio.Active = true;
                    break;
                }
            case Mixer.AudioBackend.PortAudio:
                {
                    RadioButtonPortAudio.Active = true;
                    break;
                }
            case Mixer.AudioBackend.NAudio:
                {
                    RadioButtonNAudio.Active = true;
                    break;
                }
        }

        var buttonOK = Gtk.Button.New();
        buttonOK.Label = "OK";
        buttonOK.SetValign(Gtk.Align.End);
        buttonOK.OnClicked += ButtonOK_Clicked;
        var buttonApply = Gtk.Button.New();
        buttonApply.Label = "Accept";
        buttonApply.SetValign(Gtk.Align.End);
        buttonApply.OnClicked += ButtonApply_Clicked;
        var buttonCancel = Gtk.Button.New();
        buttonCancel.Label = "Cancel";
        buttonCancel.SetValign(Gtk.Align.End);
        buttonCancel.OnClicked += ButtonCancel_Clicked;

        var buttonBox = Gtk.Box.New(Gtk.Orientation.Horizontal, 15);
        buttonBox.SetHalign(Gtk.Align.Center);
        buttonBox.SetBaselinePosition(Gtk.BaselinePosition.Bottom);
        buttonBox.SetVexpand(true);
        buttonBox.SetMarginBottom(10);
        buttonBox.Append(buttonOK);
        buttonBox.Append(buttonApply);
        buttonBox.Append(buttonCancel);

        var box = Gtk.Box.New(Gtk.Orientation.Vertical, 5);
        box.SetVexpand(true);
        box.Append(header);
        box.Append(labelAudioBackend);
        box.Append(RadioButtonMiniAudio);
        box.Append(RadioButtonPortAudio);
        box.Append(RadioButtonNAudio);
        box.Append(buttonBox);

        SetContent(box);

        OnCloseRequest += Preferences_WindowClosed;
    }

    private void ButtonOK_Clicked(Gtk.Button sender, EventArgs args)
    {
        Mixer.PlaybackBackend = PlaybackBackend;
        MainWindow.Instance!.ReloadEngine();
        Preferences_WindowClosed(null!, null!);
        Close();
    }
    private void ButtonApply_Clicked(Gtk.Button sender, EventArgs args)
    {
        Mixer.PlaybackBackend = PlaybackBackend;
        MainWindow.Instance!.ReloadEngine();
    }
    private void ButtonCancel_Clicked(Gtk.Button sender, EventArgs args)
    {
        Preferences_WindowClosed(null!, null!);
        Close();
    }

    private bool Preferences_WindowClosed(Gtk.Window sender, EventArgs args)
    {
        OnCloseRequest -= Preferences_WindowClosed;
        RadioButtonMiniAudio.OnNotify -= OnNotify_MiniAudio;
        RadioButtonPortAudio.OnNotify -= OnNotify_PortAudio;
        RadioButtonNAudio.OnNotify -= OnNotify_NAudio;
        MainWindow.Instance!.SetCanTarget(true);
        MainWindow.Instance.SetSensitive(true);
        Dispose();
        return false;
    }

    private void OnNotify_MiniAudio(object sender, EventArgs args)
    {
        if (args is NotifySignalArgs notifyArgs)
        {
            var name = notifyArgs.Pspec.GetName();
            if (name is "active" && RadioButtonMiniAudio.Active is true)
            {
                PlaybackBackend = Mixer.AudioBackend.MiniAudio;
                RadioButtonPortAudio.Active = false;
                RadioButtonNAudio.Active = false;
            }
        }
    }

    private void OnNotify_PortAudio(object sender, EventArgs args)
    {
        if (args is NotifySignalArgs notifyArgs)
        {
            var name = notifyArgs.Pspec.GetName();
            if (name is "active" && RadioButtonPortAudio.Active is true)
            {
                PlaybackBackend = Mixer.AudioBackend.PortAudio;
                RadioButtonMiniAudio.Active = false;
                RadioButtonNAudio.Active = false;
            }
        }
    }

    private void OnNotify_NAudio(object sender, EventArgs args)
    {
        if (args is NotifySignalArgs notifyArgs)
        {
            var name = notifyArgs.Pspec.GetName();
            if (name is "active" && RadioButtonNAudio.Active is true)
            {
                PlaybackBackend = Mixer.AudioBackend.NAudio;
                RadioButtonMiniAudio.Active = false;
                RadioButtonPortAudio.Active = false;
            }
        }
    }
}

So my question is, how can I change the code to work properly with what was described in that notice? I tried adding what it described in there, and removing the : Window from the class, but it just caused other issues. So I really have no idea how to approach it.

What about creating a new Adw.Window? How do I implement it now? I need to do this so I'm ready for the legacy code to be removed.

[badcel]

I just took a quick glance, so no guarantees but this are my notes / recommendations:

• Why do you call New()? If I understand correctly you create a new window which is never used? I believe the call is obsolete?
• you should be able to keep the code almost exactly like it is just use an Initialize method instead of an internal constructor: https://gircore.github.io/docs/integration/diagnostic/1002.html
• it should be possible to keep the class internal.
• you probably need to apply MemberNotNull attributes above the initialize method to get rid of nullability warnings.

I will update the documentation of 1002 to contain a sample with "MemberNotNull".

I opened: #1558

[PlatinumLucario]

That makes sense now, based on the recommendations, I now realise what I did incorrectly and made the necessary changes, and it works! Thank you!

Here's how it looks now:

using System;
using System.Runtime.InteropServices;
using Adw;
using GObject;
using Kermalis.VGMusicStudio.Core;

namespace Kermalis.VGMusicStudio.GTK4;

[Subclass<Window>]
internal partial class Preferences
{
    private Mixer.AudioBackend PlaybackBackend;

    private Gtk.CheckButton RadioButtonPortAudio { get; set; }
    private Gtk.CheckButton RadioButtonMiniAudio { get; set; }
    private Gtk.CheckButton RadioButtonNAudio { get; set; }
    
    partial void Initialize()
    {
        Title = $"Preferences - {MainWindow.GetProgramName()}";
        FocusVisible = true;
        FocusOnClick = true;

        var header = HeaderBar.New();

        var labelAudioBackend = Gtk.Label.New("Audio Backend:");

        RadioButtonMiniAudio = Gtk.CheckButton.New();
        RadioButtonMiniAudio.Label = "MiniAudio";
        RadioButtonMiniAudio.OnNotify += OnNotify_MiniAudio;
        RadioButtonPortAudio = Gtk.CheckButton.New();
        RadioButtonPortAudio.Label = "PortAudio";
        RadioButtonPortAudio.OnNotify += OnNotify_PortAudio;
        RadioButtonNAudio = Gtk.CheckButton.New();
        RadioButtonNAudio.Label = "NAudio (Legacy, Deprecated, Windows Only)";
        if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
        {
            RadioButtonNAudio.Sensitive = true;
            RadioButtonNAudio.OnNotify += OnNotify_NAudio;
        }
        else
        {
            RadioButtonNAudio.Sensitive = false;
        }
        RadioButtonPortAudio.SetGroup(RadioButtonMiniAudio);
        RadioButtonPortAudio.SetGroup(RadioButtonNAudio);
        
        switch (Mixer.PlaybackBackend)
        {
            case Mixer.AudioBackend.MiniAudio:
                {
                    RadioButtonMiniAudio.Active = true;
                    break;
                }
            case Mixer.AudioBackend.PortAudio:
                {
                    RadioButtonPortAudio.Active = true;
                    break;
                }
            case Mixer.AudioBackend.NAudio:
                {
                    RadioButtonNAudio.Active = true;
                    break;
                }
        }

        var buttonOK = Gtk.Button.New();
        buttonOK.Label = "OK";
        buttonOK.SetValign(Gtk.Align.End);
        buttonOK.OnClicked += ButtonOK_Clicked;
        var buttonApply = Gtk.Button.New();
        buttonApply.Label = "Accept";
        buttonApply.SetValign(Gtk.Align.End);
        buttonApply.OnClicked += ButtonApply_Clicked;
        var buttonCancel = Gtk.Button.New();
        buttonCancel.Label = "Cancel";
        buttonCancel.SetValign(Gtk.Align.End);
        buttonCancel.OnClicked += ButtonCancel_Clicked;

        var buttonBox = Gtk.Box.New(Gtk.Orientation.Horizontal, 15);
        buttonBox.SetHalign(Gtk.Align.Center);
        buttonBox.SetBaselinePosition(Gtk.BaselinePosition.Bottom);
        buttonBox.SetVexpand(true);
        buttonBox.SetMarginBottom(10);
        buttonBox.Append(buttonOK);
        buttonBox.Append(buttonApply);
        buttonBox.Append(buttonCancel);

        var box = Gtk.Box.New(Gtk.Orientation.Vertical, 5);
        box.SetVexpand(true);
        box.Append(header);
        box.Append(labelAudioBackend);
        box.Append(RadioButtonMiniAudio);
        box.Append(RadioButtonPortAudio);
        box.Append(RadioButtonNAudio);
        box.Append(buttonBox);

        SetContent(box);

        OnCloseRequest += Preferences_WindowClosed;
    }

    private void ButtonOK_Clicked(Gtk.Button sender, EventArgs args)
    {
        Mixer.PlaybackBackend = PlaybackBackend;
        MainWindow.Instance!.ReloadEngine();
        Preferences_WindowClosed(null!, null!);
        Close();
    }
    private void ButtonApply_Clicked(Gtk.Button sender, EventArgs args)
    {
        Mixer.PlaybackBackend = PlaybackBackend;
        MainWindow.Instance!.ReloadEngine();
    }
    private void ButtonCancel_Clicked(Gtk.Button sender, EventArgs args)
    {
        Preferences_WindowClosed(null!, null!);
        Close();
    }

    private bool Preferences_WindowClosed(Gtk.Window sender, EventArgs args)
    {
        OnCloseRequest -= Preferences_WindowClosed;
        RadioButtonMiniAudio.OnNotify -= OnNotify_MiniAudio;
        RadioButtonPortAudio.OnNotify -= OnNotify_PortAudio;
        RadioButtonNAudio.OnNotify -= OnNotify_NAudio;
        MainWindow.Instance!.SetCanTarget(true);
        MainWindow.Instance.SetSensitive(true);
        Dispose();
        return false;
    }

    private void OnNotify_MiniAudio(object sender, EventArgs args)
    {
        if (args is NotifySignalArgs notifyArgs)
        {
            var name = notifyArgs.Pspec.GetName();
            if (name is "active" && RadioButtonMiniAudio.Active is true)
            {
                PlaybackBackend = Mixer.AudioBackend.MiniAudio;
                RadioButtonPortAudio.Active = false;
                RadioButtonNAudio.Active = false;
            }
        }
    }

    private void OnNotify_PortAudio(object sender, EventArgs args)
    {
        if (args is NotifySignalArgs notifyArgs)
        {
            var name = notifyArgs.Pspec.GetName();
            if (name is "active" && RadioButtonPortAudio.Active is true)
            {
                PlaybackBackend = Mixer.AudioBackend.PortAudio;
                RadioButtonMiniAudio.Active = false;
                RadioButtonNAudio.Active = false;
            }
        }
    }

    private void OnNotify_NAudio(object sender, EventArgs args)
    {
        if (args is NotifySignalArgs notifyArgs)
        {
            var name = notifyArgs.Pspec.GetName();
            if (name is "active" && RadioButtonNAudio.Active is true)
            {
                PlaybackBackend = Mixer.AudioBackend.NAudio;
                RadioButtonMiniAudio.Active = false;
                RadioButtonPortAudio.Active = false;
            }
        }
    }
}

[badcel]

Looks good to me 👍