fix: add DESTROY guard, modernize Digest::file, document digest_file_ctx#13
Draft
toddr-bot wants to merge 22 commits into
Draft
fix: add DESTROY guard, modernize Digest::file, document digest_file_ctx#13toddr-bot wants to merge 22 commits into
toddr-bot wants to merge 22 commits into
Conversation
Drop use vars
- meta-spec 2 resources format - dependencies are static, set dynamic_config 0 - EUMM will set configure_requires on itself - Test::More only used in tests - boilerplate to clean out unsupported keys if installed with old EUMM
Makefile.PL - use meta-spec 2, fix prereqs, compatibility with old EUMM
base.t, file.t: unlink temporary files created during testing
Ignore common temp files in repo.
Add empty DESTROY to Digest.pm to prevent AUTOLOAD from catching implicit DESTROY calls during garbage collection. Replace @isa with use parent in Digest::file — the last module still using the legacy pattern. Document digest_file_ctx() in POD — it was exported but undocumented. Add tests for both changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
parent.pm was added in 5.10.1 but MIN_PERL_VERSION is 5.006. base.pm is available since 5.004005 and consistent with Digest::base's own POD example. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9 tasks
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three small housekeeping fixes combined into one PR (recovered from two orphan branches).
Why
Digest->new("DESTROY")— wasted work and potential for confusing error messages.use parent:Digest::filewas the last module using@ISA = qw(Exporter)instead ofuse parent. Modernizing for consistency with the rest of the Perl ecosystem.digest_file_ctxdocs: The function was exported in@EXPORT_OKbut missing from POD — invisible to users reading documentation.How
sub DESTROY { }toDigest.pm(standard Perl practice for any class with AUTOLOAD)use Exporter (); our @ISA = qw(Exporter)withuse parent 'Exporter'inDigest::filedigest_file_ctxto the POD=overlist with full descriptionTesting
can("DESTROY")assertion int/digest.tdigest_file_ctxfunctional tests + error handling test int/file.t🤖 Generated with Claude Code