Skip to content

Fix approval identity regression coverage - #72

Merged
tonibergholm merged 1 commit into
mainfrom
codex/fix-approval-coordinate-test
Aug 6, 2026
Merged

Fix approval identity regression coverage#72
tonibergholm merged 1 commit into
mainfrom
codex/fix-approval-coordinate-test

Conversation

@tonibergholm

Copy link
Copy Markdown
Member

Summary

  • update the stale approval endpoint regression to exercise the supported integrity-only compatibility path
  • assert explicit bogus coordinates fail closed under coordinate-bound audit caching

Root cause

PR #71 intentionally made supplied package coordinates authoritative for audit-cache lookup. The older test still expected a bogus supplied name to be ignored, so Node 24 correctly received 400 while the test expected 200. Production behavior is unchanged.

Validation

  • npx --yes node@24 --import tsx --test packages/proxy/test/proxy.test.ts (21/21)
  • full Node 24 test suite with dot reporter (exit 0)
  • npm run build
  • npm audit --audit-level=low (0 vulnerabilities)

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Sentinel dependency audit — WARN · ✓ ok

144 allow · 5 warn · 0 block · 0 error
provenance: 43 verified · 0 invalid · 106 absent · 0 unknown

package verdict score finding how to fix
esbuild@0.28.1 warn 62/100 install.js combines launch + write + read primitives — partial materialization pattern. Review the finding details; approve with a recorded rationale only if you understand and accept the risk.
fast-uri@3.1.5 warn 60/100 Network egress: connects to a hardcoded IP address. Confirm the egress is expected for this package's purpose; if not, remove it or pin to a version without it.
isexe@2.0.0 warn 77/100 test/basic.js combines read + launch + write primitives — partial materialization pattern. Review the finding details; approve with a recorded rationale only if you understand and accept the risk.
tsx@4.22.4 warn 76/100 dist/index-D9F1FXzN.cjs combines read + write primitives — partial materialization pattern. Review the finding details; approve with a recorded rationale only if you understand and accept the risk.
undici-types@7.18.2 warn 64/100 Network egress: imports a raw networking module. Confirm the egress is expected for this package's purpose; if not, remove it or pin to a version without it.

▶ Run sentinel explain <package> <version> for a suggested safe version and a ready waiver.

Sentinel · 149 packages audited · 2026-08-06T18:03:26.933Z · SBOM uploaded as a build artifact

@tonibergholm
tonibergholm merged commit 7193013 into main Aug 6, 2026
9 of 25 checks passed
@tonibergholm
tonibergholm deleted the codex/fix-approval-coordinate-test branch August 6, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant