Fix VSCode extension: command injection, resource leaks, iteration safety#1027
Open
Fix VSCode extension: command injection, resource leaks, iteration safety#1027
Conversation
Collaborator
Author
This was referenced Apr 9, 2026
jwiegley
force-pushed
the
johnw/review-vscode-extension
branch
2 times, most recently
from
aefe992 to
5780c9a
Compare
svarlamov
changed the base branch from
johnw/review-harden-scripts
to
graphite-base/1027
svarlamov
force-pushed
the
johnw/review-vscode-extension
branch
from
5780c9a to
cfb5bd0
Compare
…fety - Replace exec() with execFile() to prevent shell injection - Clear pending save timers on dispose to prevent leaked intervals - Dispose old command registration before re-registering to avoid leaks - Only snapshot active editor on tab completion, not all open documents - Await afterHook to ensure checkpoints complete before re-registration - Clear document change timer when switching documents - Use unsigned right shift for hash modulo to avoid negative indices - Collect cache keys before deleting to avoid mutating Map during iteration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
svarlamov
force-pushed
the
johnw/review-vscode-extension
branch
from
cfb5bd0 to
e78647c
Compare
Contributor
Qodana for JVMAnalyzed project: 2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com