Harden daemon: socket permissions, env safety, telemetry, rewrite locking#1029
Draft
jwiegley wants to merge 1 commit intojohnw/review-security-fixesfrom
Draft
Harden daemon: socket permissions, env safety, telemetry, rewrite locking#1029jwiegley wants to merge 1 commit intojohnw/review-security-fixesfrom
jwiegley wants to merge 1 commit intojohnw/review-security-fixesfrom
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 9, 2026
jwiegley
force-pushed
the
johnw/review-security-fixes
branch
from
bbff7f0 to
eb75b9b
Compare
jwiegley
force-pushed
the
johnw/review-harden-daemon
branch
2 times, most recently
from
79c693b to
a0f2607
Compare
jwiegley
force-pushed
the
johnw/review-security-fixes
branch
from
eb75b9b to
897edee
Compare
svarlamov
force-pushed
the
johnw/review-security-fixes
branch
from
897edee to
b43e12d
Compare
…king - Set umask(077) before creating control/trace sockets to prevent TOCTOU race with subsequent chmod - Set daemon directory permissions to 0700 - Move env var sanitization before tokio runtime build to avoid unsafe env modification from worker threads - Track dropped telemetry envelopes and CAS records via atomic counters, expose in FamilyStatus - Make watermark update a confirmed operation via oneshot channel - Scope watermark pruning to the correct worktree prefix - Add file locking for rewrite log read-modify-write cycles Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
svarlamov
force-pushed
the
johnw/review-harden-daemon
branch
from
a0f2607 to
9b1e189
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOCTOU race with subsequent chmod
unsafe env modification from worker threads
counters, expose in FamilyStatus
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com