git clone not works with some ramdisk and ntfs

[yyjdelete]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

$ git --version --build-options

git version 2.15.1.windows.2
built from commit: 5d5baf91824ec7750b103c8b7c4827ffac202feb
sizeof-long: 4
machine: x86_64

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver

Microsoft Windows [版本 10.0.17046.1000]

Also failed with some old stable versions of win10.

• What options did you set as part of the installation? Or did you choose the
  defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Editor Option: Nano
Path Option: Cmd
SSH Option: OpenSSH
CURL Option: OpenSSL
CRLF Option: CRLFCommitAsIs
Bash Terminal Option: MinTTY
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Enabled

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

Clone into an ramdisk which formated to NTFS.

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

bash/cmd

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

1. Install any ramdisk(like https://sourceforge.net/projects/imdisk-toolkit/, or you can install some others).
2. Format the ramdisk to NTFS(FAT32 works well).
3. Just clone anything on the ramdisk.

 git clone <any repository> <any dir on the ramdisk>

• What did you expect to occur after running these commands?

Clone successful.

• What actually happened instead?

Clone failed with the error message below, but the .git folder is created. Both git status and git checkout -f HEAD works.

fatal: This operation must be run in a work tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

• If the problem was occurring with a specific repository, can you provide the
  URL to that repository to help us with testing?

** insert URL here **

[yyjdelete]

Seems it's an known issue that some simple ramdisk like imdisk not works with GetFinalPathNameByHandle.(see http://docs.libuv.org/en/v1.x/fs.html, or google GetFinalPathNameByHandle ramdisk)

And found an workaround is to set core.symlinks to false. But if it's ok to add an fallback to use the old value if CreateFileW success and GetFinalPathNameByHandleW failed?

May related to #1007?

[dscho]

Install any ramdisk(like https://sourceforge.net/projects/imdisk-toolkit/, or you can install some others).
Format the ramdisk to NTFS(FAT32 works well).

I would very much appreciate it if you could provide me with a command-line how to call imdisk.exe to set this up. I'd much rather spend my time fixing Git bugs than having to chase down information you already have...

[yyjdelete]

@dscho
Mount(Z:, 128M): imdisk -a -m "Z:" -s 128M -p "/fs:ntfs /q /y"
UnMount: imdisk -D -m "Z:"

[dscho]

@yyjdelete thanks. I did that (did not elevate, so the formatting did not work, but Windows helpfully brought up a dialog whether I want to format the new drive). This is how it looks, though:

Q:\>git clone --depth 1 file:///C:\git-sdk-64\usr\src\build-extra bbb
Cloning into 'bbb'...
remote: Counting objects: 287, done.
remote: Compressing objects: 100% (256/256), done.
Receiving objects: 100% (287/287), 5.97 MiB | 11.13 MiB/s, done.
remote: Total 287 (delta 74), reused 132 (delta 17)
Resolving deltas: 100% (74/74), done.

It also works in Git Bash...

FWIW when I call imdisk --version, the output looks like this:

Control program for the ImDisk Virtual Disk Driver for Windows NT/2000/XP.
Version 2.0.9 - (Compiled Dec 15 2015)

Copyright (C) 2004-2015 Olof Lagerkvist.

http://www.ltr-data.se     olof@ltr-data.se

<BSD license text, GPL and another reference to a BSD license>

[yyjdelete]

I use the same version of imdisk, not sure what happened.
Can you check whether git config core.symlinks is set to true. This only happened with NTFS and core.symlinks=true.

[dscho]

This only happened with NTFS and core.symlinks=true

That is set automatically when initializing a repository... Git tries to create a symbolic link in .git/ and if it succeeds, it sets that setting to true.

[yyjdelete]

I mean the global/system config(or the one set by setup of GFW), instead of the local config.

[mehrdadn]

@dscho For me, this problem doesn't come up with git clone, only with other operations like git status. Any chance you could revisit this? I've included a full repro below:

To create the RAM drive:

C:\>imdisk -a -s 64M -o rem -m X: -p "/FS:NTFS /Q /S:disable /Y"
Creating device...
Created device 1: X: -> Image in memory
Formatting disk X:...
The type of the file system is RAW.
The new file system is NTFS.
QuickFormatting 64.0 MB
Creating file system structures.
Format complete.
      64.0 MB total disk space.
      61.8 MB are available.
Notifying applications...
Done.

To use it:

C:\>X:

X:\>mkdir Test

X:\>cd Test

X:\Test>git init
Initialized empty Git repository in X:/Test/.git/

X:\Test>git status
fatal: This operation must be run in a work tree

[dscho]

@mehrdadn thank you for the reproducer!

However, it does not reproduce for me...

me@work MINGW64 ~/
$ imdisk -a -s 64M -o rem -m X: -p "/FS:NTFS /Q /S:disable /Y"
The type of the file system is RAW.
The new file system is NTFS.
QuickFormatting 64.0 MB
Creating file system structures.
Format complete.
      64.0 MB total disk space.
      61.8 MB are available.
Creating device...
Created device 0: X: -> Image in memory
Formatting disk X:...
Notifying applications...
Done.

me@work MINGW64 ~/
$ cd /x/

me@work MINGW64 /x
$ mkdir Test

me@work MINGW64 /x
$ cd Test

me@work MINGW64 /x/Test
$ git init
Initialized empty Git repository in X:/Test/.git/

me@work MINGW64 /x/Test (master)
$ git status
On branch master

No commits yet

nothing to commit (create/copy files and use "git add" to track)

Also in CMD:

C:\Users\me>x:

X:\>cd Test

X:\Test>git status
On branch master

No commits yet

nothing to commit (create/copy files and use "git add" to track)

This is with git version 2.16.1.windows.4 for the purpose of this test.

[yyjdelete]

@dscho
Maybe an global or system config core.symlinks=true(can be set by the installer) is needed to reproduce

[mehrdadn]

That's so bizarre. I have core.symlinks=false and it still reproduces. I'm on 2.16.1.windows.1 currently.

[dscho]

@mehrdadn there has been a bug fix that should be unrelated (I am pretty certain it only affects worktrees in a top-level UNC path), but... could you check with the latest snapshot (use the portable installer to avoid messing with your current setup)?

[dscho]

Maybe an global or system config core.symlinks=true(can be set by the installer) is needed to reproduce

@yyjdelete nope, already set:

$ git config core.symlinks
true

[mehrdadn]

Nope it seems the problem is there on the latest snapshot too (as well as .4 etc.).
@dscho, can you reproduce this code failing below? I don't get how it's possibly succeeding (or not getting called) on your system since it uses IOCTL_MOUNTMGR_QUERY_DOS_VOLUME_PATH which fails on ImDisk.

HANDLE folder = CreateFile(TEXT("X:\\Temp"), 0, FILE_SHARE_DELETE | FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, NULL);
TCHAR path[MAX_PATH];
unsigned int const cchpath = sizeof(path) / sizeof(*path);
if (GetFinalPathNameByHandle(folder, path, cchpath, VOLUME_NAME_DOS | FILE_NAME_NORMALIZED))
{ _tprintf(_T("Suceeded: %.*s\n"), static_cast<int>(cchpath), path); }
else
{ _tprintf(_T("Failed: %lu\\n"), GetLastError()); }
CloseHandle(folder);