Match NOTICE files with a wildcard like license does - #125
Merged
Conversation
The explicit list missed NOTICES (plural) and extensions other than .md/.txt. notice* covers NOTICE, NOTICES, NOTICE.rst, NOTICE-THIRD-PARTY and so on, matching how the license entry already works.
There was a problem hiding this comment.
Pull request overview
This PR updates the shared knowledge-base resource patterns so “Notice” files are detected using a wildcard (similar to license matching), and adjusts the resource-group test to validate detection with a pluralized notice filename.
Changes:
- Changed
Noticeresource patterns from an explicit list to a wildcard pattern. - Updated
TestResourceGroupsto create and assert againstNOTICES.mdinstead ofNOTICE.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| knowledge/_shared/_resources.toml | Broadens Notice-file detection patterns to match more notice naming variants. |
| detect/detect_test.go | Updates resource-group fixture and assertion to validate the new notice matching behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Per CONTRIBUTING.md guidance for prose resource files, avoid a bare notice* which would match unrelated Notice-prefixed files in docs/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explicit
["notice", "notice.md", "notice.txt"]list missedNOTICES(plural) and extensions other than.md/.txt.notice*coversNOTICE,NOTICES,NOTICE.rst,NOTICE-THIRD-PARTYand so on, matching how thelicenseentry already useslicense*.Aligns with how
git-pkgs/licensesrecognises notice files (isLegalFileaccepts bothnoticeandnoticesprefixes).