Disable parse timeout in tests#16
Merged
Merged
Conversation
The per-file parse timeout exists to keep pathological real-world inputs from dominating a Pack run. Test fixtures are tiny and should never hit it, but on macOS CI runners under -race the Swift grammar has been observed to brush the 1s default and intermittently trip ParseStoppedEarly, failing TestOutlineSwift with 'not supported'. Recent macOS timings for TestOutlineSwift: 0.87s, 0.87s, 1.01s, 1.29s, 1.34s, 1.47s (fail), 1.55s, 2.37s (fail). Set the timeout to 0 in TestMain so correctness tests aren't also timing tests. The overall go test timeout still catches real hangs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestOutlineSwiftis flaky onmacos-latestunder-race: the Swift tree-sitter grammar is slow enough that parsing the 15-line fixture brushes the 1sDefaultParseTimeout, and runner jitter tips it intoParseStoppedEarly()→Outline()returnsok=false→ test fails withSample.swift: not supported.Recent macOS timings for that test across CI runs: 0.87s, 0.87s, 1.01s, 1.29s, 1.34s, 1.47s (fail), 1.55s, 2.37s (fail). Main is currently red with this.
The timeout exists to keep pathological real-world inputs from dominating a
Packrun; it has no business gating unit tests on tiny fixtures. Add aTestMainthat callsSetParseTimeout(0)before the suite runs so correctness tests aren't also timing tests. The overallgo testtimeout still catches a genuine hang.