fix: proper handling of upstream registry 404s#209
Open
Tilian wants to merge 2 commits into
Open
Conversation
andrew
requested changes
Jul 23, 2026
andrew
left a comment
Contributor
There was a problem hiding this comment.
Please address the remaining 404 paths:
- Add ErrUpstreamNotFound handling to the URL-based artifact handlers for Debian, RPM, NuGet, PyPI, Composer, CRAN, Julia, Conda, and Conan, with route-level tests. These paths still return 502.
- Bump github.com/git-pkgs/registries to v0.6.3, which includes the circuit-breaker fix from registries#44. Version 0.6.2 counts 404s as failures, so repeated misses eventually become 502s.
- Refactor the shared Gem and Hex error handling so the dupl lint check succeeds.
Author
|
Thanks for the super quick review! I've mapped upstream 404s for all remaining artifact handlers via a shared Per-ecosystem fetch-fail log lines are now being normalized to "failed to get artifact". The associated ecosystem can be identified through the INFO-level logging (or the URL). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208.