refactor(cli): consolidate picker implementations - #14272
Merged
Conversation
github-actions
Bot
added
rust
davidpdrsn
force-pushed
the
dp-port-pickers
branch
2 times, most recently
from
June 18, 2026 08:56
cad94f1 to
2571c97
Compare
davidpdrsn
marked this pull request as ready for review
June 18, 2026 09:08
Contributor
There was a problem hiding this comment.
Copilot encountered an error: Your billing is not configured or you have Copilot licenses from multiple standalone organizations or enterprises. To use premium requests, select a billing entity via the GitHub site, under Settings > Copilot > Features.
new picker impl
davidpdrsn
force-pushed
the
dp-port-pickers
branch
from
June 18, 2026 09:11
2571c97 to
cd65595
Compare
davidpdrsn
requested review from
Byron,
Caleb-T-Owens,
estib-vega,
krlvi,
mtsgrd,
schacon and
slarse
as code owners
June 18, 2026 09:11
slarse
approved these changes
Jun 18, 2026
slarse
left a comment
slarse
left a comment
Contributor
There was a problem hiding this comment.
Approve for push.yml change, rest is too big to review :D
krlvi
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies all CLI pickers under
InputOutputChannel::{prompt_select, prompt_multi_select}.I also removed the vendored cli-prompts crate and implemented our own picker with ratatui. I don't think its worth pulling in a whole new dependency just for a picker. I did using dialoguer first but ran into a bunch of issues with that.