fix: ensure error message text wraps#5418
Merged
Merged
Conversation
|
@MikaelCarpenter is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
MikaelCarpenter
force-pushed
the
mc-branch-1
branch
from
f7fa29d to
14ded9e
Compare
ndom91
reviewed
Nov 4, 2024
| </svelte:fragment> | ||
|
|
||
| <svelte:fragment slot="content"> | ||
| {errorMessage} |
Contributor
There was a problem hiding this comment.
Let's wrap this in a <pre> as well. Otherwise looking good though!
Text wasn't wrapping, but this looks a little more idiomatic for this codebase given how the InfoMessage component is used
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
The error message is not fully visible when a commit signing test fails.
🧢 Changes
I moved the error message into the
contentslot, because that seems to be more in-line with how theInfoMessagecomponent is used throughout the codebase. I also had to make sure the errorMessage was re-set when a new signing test was initiated. And then i added some styles to ensure that aprein the content slot would always have text wrapping.If y'all would prefer a different approach, just let me know!
📸 Screenshots