fix: remove extra spacing on InfoMessage#5494
Merged
Merged
Conversation
the parent container uses a gap, so an empty pre results in some extra padding that makes the InfoMessage asymmetric
|
@MikaelCarpenter is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
estib-vega
approved these changes
Nov 8, 2024
Contributor
estib-vega
left a comment
estib-vega
left a comment
There was a problem hiding this comment.
Thanks for the attention to detail and for the detailed PR description.
This is highly appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
In #5418 I made some changes to this
InfoMessageto render the error message properly.However, I introduced a scenario where the
contentslot could be rendered to the DOM with apreelement, but no text content.Ordinarily the content element would hide itself if empty, but the
preelement prevents that. The parent container also usesgapto add space between thetitleandcontentslots, resulting in asymmetric spacing🧢 Changes
preif there's no error message📸 Screenshots