Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOUNTY - Integrate Fortmatic into Gitcoin #5909

Open
owocki opened this issue Jan 30, 2020 · 4 comments · May be fixed by #5933
Open

BOUNTY - Integrate Fortmatic into Gitcoin #5909

owocki opened this issue Jan 30, 2020 · 4 comments · May be fixed by #5933

Comments

@owocki
Copy link
Member

@owocki owocki commented Jan 30, 2020

The scope of this bounty is to integrate formatic into Gitcoin

The winning submission for this bounty will have integrated Formatic into Gitcoin and will have tested locally

  1. Send Tip
  2. Receive Tip
  3. Create Bounty
  4. Payout Bounty
  5. Submit Bounty
  6. Create Grant
  7. Fund Grant
  8. Send Kudos
  9. Receive Kudos

on Google Chrome without Metamask. Additionally we would like to have the following browsers tested (albeit with a lighter test footprint)

  1. Brave
  2. Safari
  3. Edge

The winning submission will have updated all references to Metamask to 'Your Web3 Wallet'

The winning submission must be complete within 2 weeks of worker acceptance.

@owocki owocki changed the title BOUNTY - Integrate Formatic into Gitcoin BOUNTY - Integrate Fortmatic into Gitcoin Feb 2, 2020
@gitcoinbot

This comment has been minimized.

Copy link
Member

@gitcoinbot gitcoinbot commented Feb 2, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 2.5 ETH (479.55 USD @ $191.82/ETH) attached to it.

@gitcoinbot

This comment has been minimized.

Copy link
Member

@gitcoinbot gitcoinbot commented Feb 2, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 4 weeks from now.
Please review their action plans below:

1) damiloju has applied to start work (Funders only: approve worker | reject worker).

WIll work and doing the integration using best practices
2) kichjang has been approved to start work.

Fortmatic has a documentation link here: https://docs.fortmatic.com. At first glance, their API really isn't that much different from Web3, so I am expecting that most of the time for this issue will be spent on testing the app thoroughly and ensuring that there are no stones uncovered.

In terms of time, my bounty queue is empty right now, so I can expect to get this done in a few days once accepted.
3) developerfred has applied to start work (Funders only: approve worker | reject worker).

wow i'm dying to do this integration, even more because i'm a fan of gitcoin
4) sanchaymittal has applied to start work (Funders only: approve worker | reject worker).

Integrated multiple wallets for dapps and have a basic understanding of gitcoin code from earlier bounties.

Learn more on the Gitcoin Issue Details page.

@owocki

This comment has been minimized.

Copy link
Member Author

@owocki owocki commented Feb 3, 2020

@KiChjang just approved u . do us a favor and post an update within a day or two

@KiChjang KiChjang linked a pull request that will close this issue Feb 3, 2020
@KiChjang

This comment has been minimized.

Copy link
Contributor

@KiChjang KiChjang commented Feb 3, 2020

@owocki Ok, I just created a draft PR in #5933 and tested tipping myself locally. Functionality-wise, everything works quite finely, but there are some rough edges here and there. These will be cleaned up as I work on the PR to its polished state.

Here's a screenshot of the work in progress:
image

However, as a Metamask user myself, I would really like to be able to choose between the wallets that I want to integrate to Gitcoin. I think a full-scale migration to Fortmatic would be detrimental to existing Metamask users, and I believe we should instead defer to using the Metamask wallet if there is one, and only fall back to Fortmatic if we can't find any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.