Reserve Bounties #2163

mul1sh · 2018-09-05T18:55:05Z

Description

This PR allows funders to reserve bounties for particular users for 24 hours.

Funder Form
[x] On the funder form under Permissions Field add the following: Reserved for _.
[x] User should be able to type in a username in the input field

Issue Details
[x] The Issue Details should display that this issue is Reserved for X Contributor with the contributor's icon, linking to their profile.
[x] Only the contributor(s) that have been selected to work this issue can click start work.
[x] Group information and line the information up like this (Will Tip Extra)

Email
[x] User(s) should be notified that an issue has been reserved for them to work on.

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

Web

Testing

Yes I have tested this PR, and it will not break anything when merged into master 🙂

Refers/Fixes

Fixes #2037

- Ability to search and add a reservedFor user for a particular gitcoin issue - The reservedFor user is saved in the database together with the time they were created - The dashboard models have been updated to reflect this Partially fixes: #2037

stickler-ci · 2018-09-05T18:55:45Z

app/assets/v2/js/pages/new_bounty.js

  last_sync: new Date()
 };

+var reservedFor = "";


Strings must use singlequote. (quotes)

stickler-ci · 2018-09-05T18:55:45Z

app/assets/v2/js/pages/new_bounty.js

  });

+  // listen to reserved for changes
+  $('#reservedFor').on('select2:select', function (e) {


Unexpected space before function parentheses. (space-before-function-paren)

stickler-ci · 2018-09-05T18:55:45Z

app/assets/v2/js/pages/new_bounty.js


+  // listen to reserved for changes
+  $('#reservedFor').on('select2:select', function (e) {
+    var data = e.params.data;


Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-09-05T18:55:45Z

app/assets/v2/js/pages/new_bounty.js

        experienceLevel: data.experience_level,
        projectLength: data.project_length,
        bountyType: data.bounty_type,
+        reservedFor:reservedFor,


Missing space before value for key 'reservedFor'. (key-spacing)

stickler-ci · 2018-09-05T18:55:45Z

app/assets/v2/js/pages/new_bounty.js

        projectLength: data.project_length,
        bountyType: data.bounty_type,
+        reservedFor:reservedFor,
+        reservedForCreationDate:reservedFor !==""?new Date():null,


Missing space before value for key 'reservedForCreationDate'. (key-spacing)
Infix operators must be spaced. (space-infix-ops)
Strings must use singlequote. (quotes)

stickler-ci · 2018-09-05T18:55:45Z

app/dashboard/helpers.py

                'bounty_owner_address': bounty_issuer.get('address', ''),
                'bounty_owner_email': bounty_issuer.get('email', ''),
                'bounty_owner_name': bounty_issuer.get('name', ''),
+                'bounty_reserved_for':metadata.get('reservedFor', ''),


E231 missing whitespace after ':'

stickler-ci · 2018-09-05T18:55:46Z

app/dashboard/helpers.py

                'bounty_owner_email': bounty_issuer.get('email', ''),
                'bounty_owner_name': bounty_issuer.get('name', ''),
+                'bounty_reserved_for':metadata.get('reservedFor', ''),
+                'bounty_reserved_for_creation_date':metadata.get('reservedForCreationDate', ''),


E231 missing whitespace after ':'

stickler-ci · 2018-09-05T18:55:46Z

app/dashboard/helpers.py

                    'github_comments', 'override_status', 'last_comment_date', 'snooze_warnings_for_days',
-                    'admin_override_and_hide', 'admin_override_suspend_auto_approval', 'admin_mark_as_remarket_ready'
+                    'admin_override_and_hide', 'admin_override_suspend_auto_approval', 'admin_mark_as_remarket_ready',
+                    'bounty_reserved_for','bounty_reserved_for_creation_date'


E231 missing whitespace after ','

stickler-ci · 2018-09-05T21:24:38Z

app/assets/v2/js/pages/bounty_details.js


-var build_detail_page = function(result) {
+var set_reserved_for_link = function(result) {
+    if(result.bounty_reserved_for !== '') {


Expected indentation of 2 spaces but found 4. (indent)
Expected space(s) after "if". (keyword-spacing)

stickler-ci · 2018-09-05T21:24:39Z

app/assets/v2/js/pages/bounty_details.js

-var build_detail_page = function(result) {
+var set_reserved_for_link = function(result) {
+    if(result.bounty_reserved_for !== '') {
+      var profile_link = 'https://gitcoin.co/profile/'+result.bounty_reserved_for;


Expected indentation of 4 spaces but found 6. (indent)
Infix operators must be spaced. (space-infix-ops)

stickler-ci · 2018-09-05T21:24:39Z

app/assets/v2/js/pages/bounty_details.js

+var set_reserved_for_link = function(result) {
+    if(result.bounty_reserved_for !== '') {
+      var profile_link = 'https://gitcoin.co/profile/'+result.bounty_reserved_for;
+      var reservedForHtmlLink = '<a href="'+profile_link+'">'+result.bounty_reserved_for+'</a>';


Expected indentation of 4 spaces but found 6. (indent)
Infix operators must be spaced. (space-infix-ops)

stickler-ci · 2018-09-05T21:24:39Z

app/assets/v2/js/pages/bounty_details.js

+    if(result.bounty_reserved_for !== '') {
+      var profile_link = 'https://gitcoin.co/profile/'+result.bounty_reserved_for;
+      var reservedForHtmlLink = '<a href="'+profile_link+'">'+result.bounty_reserved_for+'</a>';
+      var reservedForAvatar = `<img class="rounded-circle" src="${static_url + 'v2/images/user-placeholder.png'}" width="30" height="30"/>`;


Expected indentation of 4 spaces but found 6. (indent)
Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-09-05T21:24:39Z

app/assets/v2/js/pages/bounty_details.js

+      var profile_link = 'https://gitcoin.co/profile/'+result.bounty_reserved_for;
+      var reservedForHtmlLink = '<a href="'+profile_link+'">'+result.bounty_reserved_for+'</a>';
+      var reservedForAvatar = `<img class="rounded-circle" src="${static_url + 'v2/images/user-placeholder.png'}" width="30" height="30"/>`;
+      $('#bounty_reserved_for').html(reservedForHtmlLink+reservedForAvatar); 


Expected indentation of 4 spaces but found 6. (indent)
Infix operators must be spaced. (space-infix-ops)
Trailing spaces not allowed. (no-trailing-spaces)

stickler-ci · 2018-09-05T21:24:39Z

app/assets/v2/js/pages/bounty_details.js

+      var reservedForAvatar = `<img class="rounded-circle" src="${static_url + 'v2/images/user-placeholder.png'}" width="30" height="30"/>`;
+      $('#bounty_reserved_for').html(reservedForHtmlLink+reservedForAvatar); 
+    }
+    else {


Expected indentation of 2 spaces but found 4. (indent)

stickler-ci · 2018-09-05T21:24:39Z

app/assets/v2/js/pages/bounty_details.js

+      $('#bounty_reserved_for').html(reservedForHtmlLink+reservedForAvatar); 
+    }
+    else {
+      $('#bounty_reserved_for').css('display', 'none');


Expected indentation of 4 spaces but found 6. (indent)

stickler-ci · 2018-09-05T21:24:39Z

app/assets/v2/js/pages/bounty_details.js

+    }
+    else {
+      $('#bounty_reserved_for').css('display', 'none');
+    }


Expected indentation of 2 spaces but found 4. (indent)

stickler-ci · 2018-09-05T21:24:40Z

app/dashboard/router.py

            'fulfillment_submitted_on', 'fulfillment_started_on', 'canceled_on', 'action_urls', 'project_type',
            'permission_type', 'attached_job_description', 'needs_review', 'github_issue_state', 'is_issue_closed',
-            'additional_funding_summary', 'paid',
+            'additional_funding_summary', 'paid','bounty_reserved_for','bounty_reserved_for_creation_date',


E231 missing whitespace after ','

stickler-ci · 2018-09-05T21:24:40Z

app/dashboard/views.py

                params['stdbounties_id'] = bounty.standard_bounties_id if not stdbounties_id else stdbounties_id
                params['interested_profiles'] = bounty.interested.select_related('profile').all()
                params['avatar_url'] = bounty.get_avatar_url(True)
+


W293 blank line contains whitespace

codecov · 2018-09-05T21:49:30Z

Codecov Report

Merging #2163 into master will decrease coverage by 0.08%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #2163      +/-   ##
==========================================
- Coverage   27.83%   27.74%   -0.09%     
==========================================
  Files         137      141       +4     
  Lines       11207    11377     +170     
  Branches     1512     1544      +32     
==========================================
+ Hits         3119     3157      +38     
- Misses       7978     8110     +132     
  Partials      110      110

Impacted Files	Coverage Δ
app/dashboard/router.py	`28.26% <ø> (ø)`	⬆️
app/dashboard/views.py	`13.42% <0%> (ø)`	⬆️
app/dashboard/models.py	`50.19% <100%> (-0.04%)`	⬇️
app/dashboard/helpers.py	`17.03% <9.09%> (-0.18%)`	⬇️
app/avatar/models.py	`26.78% <0%> (-16.08%)`	⬇️
app/avatar/admin.py	`68.42% <0%> (-10.16%)`	⬇️
app/dashboard/gas_views.py	`23.15% <0%> (-1.59%)`	⬇️
app/retail/utils.py	`12.17% <0%> (ø)`	⬆️
app/avatar/exceptions.py	`45.45% <0%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4423c4...4346bd2. Read the comment docs.

…er for the reserved for bounty

stickler-ci · 2018-09-06T16:05:43Z

app/assets/v2/js/pages/bounty_details.js


-var build_detail_page = function(result) {
+var set_reserved_for_link = function(result) {
+    if(!$.isEmptyObject(result.bounty_reserved_for)) {


Expected indentation of 2 spaces but found 4. (indent)
Expected space(s) after "if". (keyword-spacing)

stickler-ci · 2018-09-06T16:05:43Z

app/assets/v2/js/pages/bounty_details.js

-var build_detail_page = function(result) {
+var set_reserved_for_link = function(result) {
+    if(!$.isEmptyObject(result.bounty_reserved_for)) {
+      var reservedForUsername = result.bounty_reserved_for.username;


Expected indentation of 4 spaces but found 6. (indent)

stickler-ci · 2018-09-06T16:05:43Z

app/assets/v2/js/pages/bounty_details.js

+var set_reserved_for_link = function(result) {
+    if(!$.isEmptyObject(result.bounty_reserved_for)) {
+      var reservedForUsername = result.bounty_reserved_for.username;
+      var profile_link = 'https://gitcoin.co/profile/'+reservedForUsername;


Expected indentation of 4 spaces but found 6. (indent)
Infix operators must be spaced. (space-infix-ops)

stickler-ci · 2018-09-06T16:05:44Z

app/assets/v2/js/pages/bounty_details.js

+    if(!$.isEmptyObject(result.bounty_reserved_for)) {
+      var reservedForUsername = result.bounty_reserved_for.username;
+      var profile_link = 'https://gitcoin.co/profile/'+reservedForUsername;
+      var reservedForHtmlLink = '<a href="'+profile_link+'">'+reservedForUsername+'</a>';


Expected indentation of 4 spaces but found 6. (indent)
Infix operators must be spaced. (space-infix-ops)

stickler-ci · 2018-09-06T16:05:44Z

app/assets/v2/js/pages/bounty_details.js

+      var reservedForUsername = result.bounty_reserved_for.username;
+      var profile_link = 'https://gitcoin.co/profile/'+reservedForUsername;
+      var reservedForHtmlLink = '<a href="'+profile_link+'">'+reservedForUsername+'</a>';
+      var reservedForAvatar = `<img class="rounded-circle" src="${static_url + 'v2/images/user-placeholder.png'}" width="25" height="25"/>`;


Expected indentation of 4 spaces but found 6. (indent)
Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-09-06T16:05:44Z

app/assets/v2/js/pages/bounty_details.js

+      var reservedForAvatar = `<img class="rounded-circle" src="${static_url + 'v2/images/user-placeholder.png'}" width="25" height="25"/>`;
+      $('#bounty_reserved_for').html(reservedForHtmlLink+reservedForAvatar); 
+    }
+    else {


Expected indentation of 2 spaces but found 4. (indent)

stickler-ci · 2018-09-06T16:05:45Z

app/assets/v2/js/pages/bounty_details.js

+      $('#bounty_reserved_for').html(reservedForHtmlLink+reservedForAvatar); 
+    }
+    else {
+      $('#bounty_reserved_for').css('display', 'none');


Expected indentation of 4 spaces but found 6. (indent)

app/assets/v2/js/pages/new_bounty.js

stickler-ci · 2018-09-06T16:05:45Z

app/assets/v2/js/pages/new_bounty.js

+  $('#reservedFor').on('select2:select', function(e) {
+    var data = e.params.data;
+    reservedFor = {
+      username:data.text,


Missing space before value for key 'username'. (key-spacing)

stickler-ci · 2018-09-06T16:05:45Z

app/assets/v2/js/pages/new_bounty.js

+      username:data.text,
+      creation_date: new Date(),
+      email: data.email,
+      avatar_url:''


Missing space before value for key 'avatar_url'. (key-spacing)

… first 24 hours, after that it will be open to everyone else

stickler-ci · 2018-09-06T19:28:37Z

app/assets/v2/js/pages/bounty_details.js

    e.preventDefault();
    if ($(this).attr('href') == '/interested') {
-      show_interest_modal.call(this);
+      if(currentLoggedInUser.length > 0 && reservedForUsername.length > 0){


Expected space(s) after "if". (keyword-spacing)
Missing space before opening brace. (space-before-blocks)

stickler-ci · 2018-09-06T19:28:37Z

app/assets/v2/js/pages/bounty_details.js

    if ($(this).attr('href') == '/interested') {
-      show_interest_modal.call(this);
+      if(currentLoggedInUser.length > 0 && reservedForUsername.length > 0){
+        if(currentLoggedInUser === reservedForUsername){


Expected space(s) after "if". (keyword-spacing)
Missing space before opening brace. (space-before-blocks)

stickler-ci · 2018-09-06T19:28:37Z

app/assets/v2/js/pages/bounty_details.js

+      if(currentLoggedInUser.length > 0 && reservedForUsername.length > 0){
+        if(currentLoggedInUser === reservedForUsername){
+          show_interest_modal.call(this);
+        }


Closing curly brace does not appear on the same line as the subsequent block. (brace-style)

stickler-ci · 2018-09-06T19:28:37Z

app/assets/v2/js/pages/bounty_details.js

+        if(currentLoggedInUser === reservedForUsername){
+          show_interest_modal.call(this);
+        }
+        else{


Expected space(s) after "else". (keyword-spacing)

stickler-ci · 2018-09-06T19:28:38Z

app/assets/v2/js/pages/bounty_details.js

+          var reservedForHoursLeft = 24 - Math.abs(new Date() - new Date(reservedForCreationDate)) / 36e5;
+          var errorMsg = '';
+
+          if(Math.round(reservedForHoursLeft) > 1){


Expected space(s) after "if". (keyword-spacing)
Missing space before opening brace. (space-before-blocks)

stickler-ci · 2018-09-06T19:28:40Z

app/assets/v2/js/pages/bounty_details.js

+      var reservedForHtmlLink = '<a href="'+profile_link+'">'+reservedForUsername+'</a>';
+      // show a static image for now becase the search is not returning an image
+      var reservedForAvatar = `<img class="rounded-circle" src="${static_url + 'v2/images/user-placeholder.png'}" width="25" height="25"/>`;
+      $('#bounty_reserved_for').html(reservedForHtmlLink+reservedForAvatar); 


Infix operators must be spaced. (space-infix-ops)
Trailing spaces not allowed. (no-trailing-spaces)

stickler-ci · 2018-09-06T19:28:40Z

app/assets/v2/js/pages/bounty_details.js

+      // show a static image for now becase the search is not returning an image
+      var reservedForAvatar = `<img class="rounded-circle" src="${static_url + 'v2/images/user-placeholder.png'}" width="25" height="25"/>`;
+      $('#bounty_reserved_for').html(reservedForHtmlLink+reservedForAvatar); 
+    }


Closing curly brace does not appear on the same line as the subsequent block. (brace-style)

stickler-ci · 2018-09-06T19:28:40Z

app/assets/v2/js/pages/bounty_details.js

+      $('#bounty_reserved_for_label').css('display', 'none');
+    }
+
+  }


Closing curly brace does not appear on the same line as the subsequent block. (brace-style)

stickler-ci · 2018-09-06T19:28:40Z

app/assets/v2/js/pages/new_bounty.js

+  // listen to reserved for changes
+  $('#reservedFor').on('select2:select', function(e) {
+
+    var data = e.params.data;


Expected blank line after variable declarations. (newline-after-var)

app/dashboard/views.py

…n created by the funder

stickler-ci · 2018-09-06T20:45:29Z

app/assets/v2/js/pages/bounty_details.js

    e.preventDefault();
    if ($(this).attr('href') == '/interested') {
-      show_interest_modal.call(this);
+      if( currentLoggedInUser.length > 0 && reservedForUsername.length > 0) {


Expected space(s) after "if". (keyword-spacing)
There should be no spaces inside this paren. (space-in-parens)

stickler-ci · 2018-09-06T20:45:29Z

app/assets/v2/js/pages/bounty_details.js

+      if( currentLoggedInUser.length > 0 && reservedForUsername.length > 0) {
+        if (currentLoggedInUser === reservedForUsername) {
+          show_interest_modal.call(this);
+        }


Closing curly brace does not appear on the same line as the subsequent block. (brace-style)

stickler-ci · 2018-09-06T20:45:29Z

app/assets/v2/js/pages/bounty_details.js

+          var errorMsg = '';
+
+          if (Math.round(reservedForHoursLeft) > 1) {
+            errorMsg = 'This issue is currently reserved for ' + reservedForUsername + ', please try to [Start Work] again after the next ' + Math.round(reservedForHoursLeft) +' hours'


Infix operators must be spaced. (space-infix-ops)
Missing semicolon. (semi)

app/assets/v2/js/pages/bounty_details.js

stickler-ci · 2018-09-06T20:45:30Z

app/assets/v2/js/pages/bounty_details.js

+    var reservedForHoursLeft = 24 - Math.abs(new Date() - new Date(reservedForCreationDate)) / 36e5;
+
+    // check if 24 hours have passed before setting the issue as reserved
+    if (Math.round(reservedForHoursLeft) > 0){


Missing space before opening brace. (space-before-blocks)

stickler-ci · 2018-09-06T20:45:30Z

app/assets/v2/js/pages/bounty_details.js

+      var profile_link = 'https://gitcoin.co/profile/'+reservedForUsername;
+      var reservedForHtmlLink = '<a href="'+profile_link+'">'+reservedForUsername+'</a>';
+      // show a static image for now becase the search is not returning an image
+      var reservedForAvatar = `<img class="rounded-circle" src="${static_url + 'v2/images/user-placeholder.png'}" width="25" height="25"/>`;


Expected blank line after variable declarations. (newline-after-var)

app/assets/v2/js/pages/change_bounty.js

app/dashboard/helpers.py

app/dashboard/views.py

stickler-ci · 2018-09-06T20:58:24Z

app/assets/v2/js/pages/bounty_details.js

+      if (currentLoggedInUser.length > 0 && reservedForUsername.length > 0) {
+        if (currentLoggedInUser === reservedForUsername) {
+          show_interest_modal.call(this);
+        }


Closing curly brace does not appear on the same line as the subsequent block. (brace-style)

stickler-ci · 2018-09-06T20:58:25Z

app/assets/v2/js/pages/bounty_details.js

+          var errorMsg = '';
+
+          if (Math.round(reservedForHoursLeft) > 1) {
+            errorMsg = 'This issue is currently reserved for ' + reservedForUsername + ', please try to [Start Work] again after the next ' + Math.round(reservedForHoursLeft) +' hours';


Infix operators must be spaced. (space-infix-ops)

stickler-ci · 2018-09-06T20:58:25Z

app/assets/v2/js/pages/bounty_details.js

+
+    // check if 24 hours have passed before setting the issue as reserved
+    if (Math.round(reservedForHoursLeft) > 0) {
+      var profile_link = 'https://gitcoin.co/profile/'+reservedForUsername;


Infix operators must be spaced. (space-infix-ops)

stickler-ci · 2018-09-06T20:58:25Z

app/assets/v2/js/pages/bounty_details.js

+    // check if 24 hours have passed before setting the issue as reserved
+    if (Math.round(reservedForHoursLeft) > 0) {
+      var profile_link = 'https://gitcoin.co/profile/'+reservedForUsername;
+      var reservedForHtmlLink = '<a href="'+profile_link+'">' + reservedForUsername + '</a>';


Infix operators must be spaced. (space-infix-ops)

stickler-ci · 2018-09-06T20:58:25Z

app/assets/v2/js/pages/bounty_details.js

+      var profile_link = 'https://gitcoin.co/profile/'+reservedForUsername;
+      var reservedForHtmlLink = '<a href="'+profile_link+'">' + reservedForUsername + '</a>';
+      // show a static image for now becase the search is not returning an image
+      var reservedForAvatar = `<img class="rounded-circle" src="${ static_url + 'v2/images/user-placeholder.png'}" width="25" height="25"/>`;


Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-09-06T20:58:25Z

app/assets/v2/js/pages/bounty_details.js

+      // show a static image for now becase the search is not returning an image
+      var reservedForAvatar = `<img class="rounded-circle" src="${ static_url + 'v2/images/user-placeholder.png'}" width="25" height="25"/>`;
+      $('#bounty_reserved_for').html(reservedForHtmlLink + reservedForAvatar);
+    }


Closing curly brace does not appear on the same line as the subsequent block. (brace-style)

stickler-ci · 2018-09-06T20:58:25Z

app/assets/v2/js/pages/bounty_details.js

+    else {
+      $('#bounty_reserved_for').css('display', 'none');
+      $('#bounty_reserved_for_label').css('display', 'none');
+    } 


Trailing spaces not allowed. (no-trailing-spaces)

stickler-ci · 2018-09-06T20:58:25Z

app/assets/v2/js/pages/bounty_details.js

+      $('#bounty_reserved_for').css('display', 'none');
+      $('#bounty_reserved_for_label').css('display', 'none');
+    } 
+  }


Closing curly brace does not appear on the same line as the subsequent block. (brace-style)

stickler-ci · 2018-09-06T21:10:42Z

app/assets/v2/js/pages/bounty_details.js

+    } else {
+      $('#bounty_reserved_for').css('display', 'none');
+      $('#bounty_reserved_for_label').css('display', 'none');
+    } 


Trailing spaces not allowed. (no-trailing-spaces)

stickler-ci · 2018-09-06T21:10:42Z

app/dashboard/helpers.py

+            body1 = '<p>Hi ' + bounty_reserved_for['username'] + ',<br><br>'
+            body2 = 'An issue has been assigned to you on gitcoin. Please start working on it in the next 24 hours,'
+            body3 = ' otherwise it will be opened up for other bounty hunters as well.<br><br>Regards</p>'
+            send_mail('founders@gitcoin.co', bounty_reserved_for['email'], 'Reserved Issue', str(body1 + body2 + body3), html=True)


E501 line too long (131 > 120 characters)

stickler-ci · 2018-09-06T21:10:43Z

app/dashboard/helpers.py

+            body2 = 'An issue has been assigned to you on gitcoin. Please start working on it in the next 24 hours,'
+            body3 = ' otherwise it will be opened up for other bounty hunters as well.<br><br>Regards</p>'
+            send_mail('founders@gitcoin.co', bounty_reserved_for['email'], 'Reserved Issue', str(body1 + body2 + body3), html=True)
+


W293 blank line contains whitespace

stickler-ci · 2018-09-06T21:10:43Z

app/dashboard/views.py

            raise Http404

-    keys = ['experience_level', 'project_length', 'bounty_type', 'permission_type', 'project_type']
+    keys = ['experience_level', 'project_length', 'bounty_type', 'permission_type', 'project_type', 


W291 trailing whitespace

stickler-ci · 2018-09-06T21:16:05Z

app/dashboard/helpers.py

+            body2 = 'An issue has been assigned to you on gitcoin.'
+            body3 = ' Please start working on it in the next 24 hours,'
+            body4 = ' otherwise it will be opened up for other bounty hunters as well.<br><br>Regards</p>'
+            send_mail('founders@gitcoin.co', bounty_reserved_for['email'], 'Reserved Issue', str(body1 + body2 + body3 + body4), html=True)


E501 line too long (139 > 120 characters)

stickler-ci · 2018-09-06T21:16:06Z

app/dashboard/helpers.py

+            body3 = ' Please start working on it in the next 24 hours,'
+            body4 = ' otherwise it will be opened up for other bounty hunters as well.<br><br>Regards</p>'
+            send_mail('founders@gitcoin.co', bounty_reserved_for['email'], 'Reserved Issue', str(body1 + body2 + body3 + body4), html=True)
+


W293 blank line contains whitespace

stickler-ci · 2018-09-06T21:24:51Z

app/dashboard/helpers.py

+            body3 = ' Please start working on it in the next 24 hours,'
+            body4 = ' otherwise it will be opened up for other bounty hunters as well'
+            body5 = '.<br><br>Regards</p>'
+            send_mail('founders@gitcoin.co', bounty_reserved_for['email'], 'Reserved Issue', str(body1 + body2 + body3 + body4 + body5), html=True)


E501 line too long (147 > 120 characters)

stickler-ci · 2018-09-06T21:24:51Z

app/dashboard/helpers.py

+            body4 = ' otherwise it will be opened up for other bounty hunters as well'
+            body5 = '.<br><br>Regards</p>'
+            send_mail('founders@gitcoin.co', bounty_reserved_for['email'], 'Reserved Issue', str(body1 + body2 + body3 + body4 + body5), html=True)
+


W293 blank line contains whitespace

stickler-ci · 2018-09-06T21:30:29Z

app/dashboard/helpers.py

+            body3 = ' Please start working on it in the next 24 hours,'
+            body4 = ' otherwise it will be opened up for other bounty hunters as well'
+            body5 = '.<br><br>Regards</p>'
+


W293 blank line contains whitespace

stickler-ci · 2018-09-06T21:30:29Z

app/dashboard/helpers.py

+            body4 = ' otherwise it will be opened up for other bounty hunters as well'
+            body5 = '.<br><br>Regards</p>'
+
+            send_mail('founders@gitcoin.co', 


W291 trailing whitespace

stickler-ci · 2018-09-06T21:30:29Z

app/dashboard/helpers.py

+            body5 = '.<br><br>Regards</p>'
+
+            send_mail('founders@gitcoin.co', 
+                      bounty_reserved_for['email'], 


W291 trailing whitespace

stickler-ci · 2018-09-06T21:30:30Z

app/dashboard/helpers.py

+
+            send_mail('founders@gitcoin.co', 
+                      bounty_reserved_for['email'], 
+                      'Reserved Issue', 


W291 trailing whitespace

stickler-ci · 2018-09-06T21:30:30Z

app/dashboard/helpers.py

+            send_mail('founders@gitcoin.co', 
+                      bounty_reserved_for['email'], 
+                      'Reserved Issue', 
+                      str(body1 + body2 + body3 + body4 + body5), 


W291 trailing whitespace

stickler-ci · 2018-09-10T18:07:06Z

app/assets/v2/js/pages/bounty_details.js

-      show_interest_modal.call(this);
+      const reservedForHoursLeft = 24 - Math.abs(new Date() - new Date(reservedForCreationDate)) / 36e5;
+
+      if ((currentLoggedInUser.length > 0 && reservedForUsername.length > 0) &&  reservedForHoursLeft > 0) {


Multiple spaces found before 'reservedForHoursLeft'. (no-multi-spaces)

PixelantDesign · 2018-09-10T18:11:49Z

@thelostone-mc
What would be the reasoning to not enable for contest and cooperative? Those workers need to get paid as well, no?

vs77bb · 2018-09-10T19:06:02Z

@PixelantDesign I think @thelostone-mc was thinking bounties that are contests / cooperative by definition can't be reserved for one person.

I think that makes sense -- it should only be for traditional bounties.

mul1sh · 2018-09-10T21:38:38Z

@thelostone-mc here is a link to a video showing the UI changes https://vimeo.com/289170255 . I have implemented the changes requested and so I hope its shows everything clearly. I've also pushed some bug fixes as requested so kindly check on them as well 😃 thanks.

cc @PixelantDesign @vs77bb

PixelantDesign · 2018-09-10T22:25:16Z

Looks pretty good....is there a reason for the large amount of space between Reserved for and the name of the user?

mul1sh · 2018-09-10T22:31:03Z

@PixelantDesign not really, let me reduce the space

mul1sh · 2018-09-10T23:22:55Z

@PixelantDesign it now looks like this, hope this is ok

PixelantDesign · 2018-09-11T03:38:07Z

looks good thanks!

Ho about the rest? Looks like Permissions is far away from Approval Required. Could you check all resolutions? Any reason the placements changed?

mul1sh · 2018-09-11T05:50:52Z

@PixelantDesign sorry for that, the above fix had some issues but i've pushed the correct one

mul1sh · 2018-09-11T10:30:42Z

@thelostone-mc @PixelantDesign any more changes to be made in this PR? thanks 🙂

thelostone-mc · 2018-09-11T18:21:28Z

LGTM! could you

fix the css spacing before { (as mentioned in the comments)
rebase + resolve conflicts
squash the commits into not more than 3

cc @mbeacom / @SaptakS if in case you wanna check it out

thelostone-mc · 2018-09-11T18:22:05Z

app/assets/v2/css/bounty.css

  padding: 1em 0;
 }

+#bounty-info-row{


space before {

thelostone-mc · 2018-09-11T18:22:09Z

app/assets/v2/css/bounty.css

+  width: 100%;
+}
+
+.bounty-info-row-span-left{


space before {

thelostone-mc · 2018-09-11T18:22:13Z

app/assets/v2/css/bounty.css

+  float: left;
+}
+
+.bounty-info-row-span-right{


space before {

thelostone-mc · 2018-09-11T18:22:18Z

app/assets/v2/css/bounty.css

  font-weight: bold;
 }

+#bounty_reserved_for a{


space before {

thelostone-mc · 2018-09-11T18:22:22Z

app/assets/v2/css/bounty.css

  transform: none;
 }

+#bounty_reserved_for img{


space before {

vs77bb · 2018-09-11T18:44:07Z

@mul1sh @thelostone-mc My only other comment: can we automatically put this issue in 'Work Started' and list the 'Reserved' individual as under 'Work Started'?

This will avoid confusion on the Issue Explorer as the issue won't show up as 'Open'.

Outside of the scope for this ticket (it wasn't listed in #2037), but perhaps in a v2 we can send an e-mail / inbox notification to the Gitcoiner in question to have them confirm they are willing to work the bounty. For v1, I think we can assume that the Reserve bounty will be used in cases they know that a particular individual will do the work.

mul1sh · 2018-09-11T19:00:28Z

@thelostone-mc thanks for the feedback, sorting it now

Edit
@thelostone-mc actually let me close this PR and make another one with the changes @vs77bb wanted, because rebasing it is proving difficult because of the many commits.

mul1sh · 2018-09-11T19:03:23Z

@vs77bb sure, i'll re-implement it this way

PixelantDesign · 2018-10-08T17:40:29Z

@mul1sh is there a reason this was closed?

mul1sh · 2018-10-08T17:55:05Z

@PixelantDesign apologies for closing this, but I explained why here and I also re-opened the PR here which is basically a duplicate of this PR.

PixelantDesign · 2018-10-08T20:04:57Z

ok! thanks!

mulili added 2 commits September 5, 2018 20:02

initial commit

708c52d

This commit has the following changes

071b44c

- Ability to search and add a reservedFor user for a particular gitcoin issue - The reservedFor user is saved in the database together with the time they were created - The dashboard models have been updated to reflect this Partially fixes: #2037

stickler-ci reviewed Sep 5, 2018

View reviewed changes

mbeacom changed the title ~~WIP PR~~ [WIP] Reserve Bounties Sep 5, 2018

mbeacom added in progress labels Sep 5, 2018

- Added the reserved for username and avatar to the issue details page

7662423

stickler-ci reviewed Sep 5, 2018

View reviewed changes

switched to using a json field instead of 3 seperate DB fields to cat…

3ca12d4

…er for the reserved for bounty

stickler-ci reviewed Sep 6, 2018

View reviewed changes

-Only reserved users will be allowed to start work on an issue in the…

40df607

… first 24 hours, after that it will be open to everyone else

stickler-ci reviewed Sep 6, 2018

View reviewed changes

- Reserved for user will get notified by email once the issue has bee…

da64dbd

…n created by the funder

stickler-ci reviewed Sep 6, 2018

View reviewed changes

lint fixes

7b9d165

stickler-ci reviewed Sep 6, 2018

View reviewed changes

lint fixes

86c0c2b

stickler-ci reviewed Sep 6, 2018

View reviewed changes

mulili added 2 commits September 7, 2018 00:10

lint fixes

37793ad

lint fixes

4b849fb

stickler-ci reviewed Sep 6, 2018

View reviewed changes

lint fixes

1e4d627

stickler-ci reviewed Sep 6, 2018

View reviewed changes

lint fixes

bfb2afb

stickler-ci reviewed Sep 6, 2018

View reviewed changes

mulili added 2 commits September 7, 2018 00:32

lint fixes

b51b7a6

lint fixes

bca8ef1

mul1sh changed the title ~~[WIP] Reserve Bounties~~ Reserve Bounties Sep 6, 2018

gitcoinbot mentioned this pull request Sep 7, 2018

BUILD - Reserve Bounties #2037

Closed

6 tasks

thelostone-mc requested a review from SaptakS September 10, 2018 09:18

bug fixes

8a1d4e6

stickler-ci reviewed Sep 10, 2018

View reviewed changes

bug fixes

712b6c7

bug fixes

178c329

fixed reserved for spacing

3a7ab06

fixed spacing

4346bd2

thelostone-mc reviewed Sep 11, 2018

View reviewed changes

app/assets/v2/css/bounty.css

padding: 1em 0;

}

#bounty-info-row{

Copy link

Contributor

thelostone-mc Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before {

thelostone-mc reviewed Sep 11, 2018

View reviewed changes

app/assets/v2/css/bounty.css

width: 100%;

}

.bounty-info-row-span-left{

Copy link

Contributor

thelostone-mc Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before {

thelostone-mc reviewed Sep 11, 2018

View reviewed changes

app/assets/v2/css/bounty.css

float: left;

}

.bounty-info-row-span-right{

Copy link

Contributor

thelostone-mc Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before {

thelostone-mc reviewed Sep 11, 2018

View reviewed changes

app/assets/v2/css/bounty.css

font-weight: bold;

}

#bounty_reserved_for a{

Copy link

Contributor

thelostone-mc Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before {

thelostone-mc reviewed Sep 11, 2018

View reviewed changes

app/assets/v2/css/bounty.css

transform: none;

}

#bounty_reserved_for img{

Copy link

Contributor

thelostone-mc Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before {

mul1sh closed this Sep 11, 2018

mbeacom removed the in progress label Sep 11, 2018

Uh oh!

Reserve Bounties #2163

Reserve Bounties #2163

Uh oh!

Conversation

mul1sh commented Sep 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mul1sh commented Sep 5, 2018 •

edited

Loading

codecov bot commented Sep 5, 2018 •

edited

Loading