Skip to content

Conversation

@aashutoshrathi
Copy link
Contributor

Description

This PR improves SEO with #2231

Checklist
Refers/Fixes

Fixes #2898

Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@aashutoshrathi aashutoshrathi changed the title 🔍 Improving SEO Improving SEO Jan 14, 2019
@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #3528 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3528      +/-   ##
==========================================
- Coverage   29.73%   29.69%   -0.05%     
==========================================
  Files         192      192              
  Lines       14840    14840              
  Branches     1963     1963              
==========================================
- Hits         4413     4407       -6     
- Misses      10278    10284       +6     
  Partials      149      149
Impacted Files Coverage Δ
app/dashboard/gas_views.py 23.46% <ø> (ø) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e2a4a...02da83d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #3528 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3528      +/-   ##
=========================================
- Coverage   29.64%   29.6%   -0.05%     
=========================================
  Files         185     185              
  Lines       14667   14667              
  Branches     1937    1937              
=========================================
- Hits         4348    4342       -6     
- Misses      10180   10186       +6     
  Partials      139     139
Impacted Files Coverage Δ
app/dashboard/gas_views.py 23.46% <ø> (ø) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93acf59...c9e7386. Read the comment docs.

@thelostone-mc thelostone-mc self-requested a review January 16, 2019 14:46
@thelostone-mc thelostone-mc merged commit 318ebfb into gitcoinco:master Jan 16, 2019
@aashutoshrathi
Copy link
Contributor Author

Thanks @thelostone-mc 😄

@gitcoinbot gitcoinbot mentioned this pull request Jan 16, 2019
2 tasks
@aashutoshrathi aashutoshrathi deleted the seo-fixes branch January 16, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants