Issue Trust Bonus as a W3C Verifiable Credential to 3Box by wyc · Pull Request #9032 · gitcoinco/web

wyc · 2021-06-09T18:29:20Z

Description

This change allows users to download their Trust Bonus as a signed W3C Verifiable Credential to their local machine or 3Box profile in addition to minting an NFT. This can then be used to demonstrate their Trust Bonus anywhere supporting the same global data standards. The signing happens with a did-web DID from gitcoin.co, but this component can be further decentralized in the future using ENS + did-eth.

Progress:

Implement W3C Verifiable Credential issuance
Integrate storage of credentials into 3Box
Implement demo application to load credentials from 3Box and verify them
Complete tests to hit the endpoint and verify the credential retrieved

A demo deployment with this PR incorporated can be found here: https://gitcoin-demo.spruceid.com/

Tool to retrieve & test the credential: https://demo.spruceid.com/popp/tools/

did-web JSON source: https://gitcoin-demo.spruceid.com/.well-known/did.json

Refers/Fixes

#8811

Testing

thelostone-mc

Will need to review this further as though isolated. It introduces

typescript
svelte
tailwind
it's own linter + webpack config

thelostone-mc · 2021-06-10T10:42:02Z

app/app/settings.py

 GTC_DIST_KEY = env('GTC_DIST_KEY', default='')
+DIDKIT_KEY_JWK = env.json('DIDKIT_KEY_JWK', default={})
+POPP_VC_ISSUER = env.str('POPP_VC_ISSUER', default='')
+POPP_VC_VERIFIER = env.str('POPP_VC_VERIFIER', default='')


^ could we add in doc on where this would be populated from

Added in 0523e1b

thelostone-mc · 2021-06-10T10:43:05Z

app/app/urls.py


    #passport
    re_path(r'^passport/$', passport.views.index, name='passport_gen'),
+    re_path(r'^passport-vc$', passport.views.verifiable_credential, name='passport_vc'),


could we rename it tp passport/verify-credentials

Resolved in 17ac7e5

thelostone-mc · 2021-06-10T10:45:02Z

app/passport/views.py

    return JsonResponse(context)
+
+
+def verifiable_credential(request):


let's use the login decorator that django offers
@login_required

Resolved in 91afdb8

thelostone-mc · 2021-06-10T10:45:20Z

app/passport/views.py

+    network = request.GET.get("network")
+
+    if not request.user.is_authenticated:
+        return JsonResponse({"status": "error", "msg": "You must login"})


^ this can be removed since we are using the decorator

Resolved in 91afdb8

thelostone-mc · 2021-06-10T10:47:26Z

ops/popp-tools/public/index.html

+</head>
+
+<body></body>
+</html>


^ reindent to 2 spaces

Done in 5ad8ee2

theosirian · 2021-06-14T15:08:06Z

The issues that were listed above have been resolved in the latest commits. It's ready for another review, especially the doc section, since I wasn't sure about the level of detail to use there.

theosirian · 2021-06-14T17:44:21Z

Rebased onto current master.

thelostone-mc · 2021-06-15T08:00:38Z

The code looks alright to me but I'm not very comfortable on adding

ts
svelte
the custom webpack / lint config files

Can this not be done outside this repo and we just end up including the minified file @wyc / @theosirian

cc @octavioamu / @gdixon / @chibie / @zacheryschiller could you guys check this out as well ?

Also from UI I'm not sure this sticks to out styleguide / presskit.
@willsputra / @PixelantDesign could you guys check this and drop in feedback ?

wyc · 2021-06-15T15:16:51Z

Sure thing, we will move it out of this PR for now. Perhaps a good home for it is https://github.com/gitcoinco/PersonhoodPassport

wyc · 2021-06-15T17:02:30Z

The items mentioned in #9032 (comment) have been moved into gitcoinco/PersonhoodPassport#1.

Ready for another review, thanks!

octavioamu

looking nice, left a few comments about functions and data that already exist.

octavioamu · 2021-07-26T13:16:46Z

app/assets/v2/js/pages/profile-trust.js

+      const accounts = web3.eth.getAccounts();
+
+      $.when(accounts).then((result) => {
+        ethAddress = result[0];
+        ethProvider = web3.currentProvider;


there are already some methods used on wallet.js that could be used here instead. You will find some global variables like selectedAccount, provider and others generated when someone connect to the site using web3modal

Resolved in e32dea6.

octavioamu · 2021-07-26T13:21:06Z

app/assets/v2/js/pages/profile-trust.js

+    const vcCopy = () => {
+      const str = JSON.stringify(credential, null, 2);
+
+      navigator.clipboard.writeText(str);
+    };


please use the code on clipboard.js
you can use it like
Copy Text

this string will be copied

is not using the last clipboard api but that could be updated if required (we already did it on our clipboard component in vue-components.js

Resolved in e32dea6.

theosirian · 2021-07-29T19:27:17Z

Resolved the changes requested by @octavioamu and rebased onto current master.

obstropolos · 2021-09-16T04:42:52Z

Hey @octavioamu - we've since migrated this to Ceramic. We're ready for another review - thanks!

credential issuer

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

…o clipboard script Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

anil2307 · 2021-10-23T09:31:20Z

kuvvet itlir

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch from 17dd2c1 to cbecdf9 Compare June 9, 2021 19:10

wyc marked this pull request as ready for review June 9, 2021 19:16

wyc requested review from PixelantDesign, chibie, frankchen07, gdixon, octavioamu, thelostone-mc and zlsgh as code owners June 9, 2021 19:16

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch from 49978e0 to 94faf41 Compare June 9, 2021 20:16

thelostone-mc reviewed Jun 10, 2021

View reviewed changes

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch from 0523e1b to 21eda8e Compare June 14, 2021 17:43

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch from 21eda8e to 3ab6fd7 Compare June 15, 2021 16:50

wyc mentioned this pull request Jun 15, 2021

Add verification tool for Trust Bonus verifications gitcoinco/PersonhoodPassport#1

Open

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch 3 times, most recently from a994cde to 8132353 Compare June 28, 2021 14:43

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch 3 times, most recently from ef9e5dd to d260dfb Compare July 14, 2021 14:02

octavioamu suggested changes Jul 26, 2021

View reviewed changes

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch from d260dfb to e32dea6 Compare July 29, 2021 19:25

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch from e32dea6 to 8b741f7 Compare August 26, 2021 19:41

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch from 8b741f7 to 12e4ea9 Compare September 16, 2021 00:57

theosirian added 14 commits September 29, 2021 11:54

Add passport-vc endpoint; Add 3box integration

eec6b0a

Add feedback to user about state of workflow; Add env variable for

47bb88d

credential issuer

Remove SpruceID button from modal

7bbdd51

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

Fix passport-vc URL; Fix POPP_VC_ISSUER env var

70965d4

Add passport-vc test file

8a4e658

Add passport-vc test to testpaths

409e94d

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

Refactor into VerifiableCredential section

3d2dac7

Change passport vc endpoint name

43f17aa

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

Refactor endpoint to use login_required decorator

d14748a

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

Change assertTrue(not var) to assertFalse(var) in passport-vc test

18f0d20

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

Add docs about new env vars

251ec41

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

Use global variables for account and provider; Use centralized copy t…

d15c9d3

…o clipboard script Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

Migrate to VC storage to IDX/Ceramic

8b6f6df

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

Add Ceramic Node URL to initializeClient

5df725d

Signed-off-by: Tiago Nascimento <tiago.nascimento@spruceid.com>

theosirian force-pushed the spruceid/feature/trust-bonus-issuance branch from 12e4ea9 to 5df725d Compare September 29, 2021 14:54

wyc requested a review from nutrina as a code owner November 24, 2021 14:32

thelostone-mc force-pushed the master branch from e276966 to df02065 Compare November 24, 2021 14:40

wyc requested a review from tim-schultz as a code owner March 8, 2022 20:59

thelostone-mc force-pushed the master branch from 7085b43 to 02b86d1 Compare March 9, 2022 14:01

gdixon force-pushed the master branch 3 times, most recently from a15aeb3 to c0d45b0 Compare May 24, 2022 22:55

		return JsonResponse(context)


		def verifiable_credential(request):

Uh oh!

Conversation

wyc commented Jun 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Refers/Fixes

Testing

Uh oh!

thelostone-mc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theosirian commented Jun 14, 2021

Uh oh!

theosirian commented Jun 14, 2021

Uh oh!

thelostone-mc commented Jun 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wyc commented Jun 15, 2021

Uh oh!

wyc commented Jun 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

octavioamu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theosirian commented Jul 29, 2021

Uh oh!

obstropolos commented Sep 16, 2021

Uh oh!

anil2307 commented Oct 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wyc commented Jun 9, 2021 •

edited

Loading

thelostone-mc commented Jun 15, 2021 •

edited

Loading

wyc commented Jun 15, 2021 •

edited

Loading