Skip to content

Keep Linux updates within startup health deadline - #34

Merged
gitcommit90 merged 1 commit into
mainfrom
fix/linux-update-startup-health
Jul 29, 2026
Merged

Keep Linux updates within startup health deadline#34
gitcommit90 merged 1 commit into
mainfrom
fix/linux-update-startup-health

Conversation

@gitcommit90

@gitcommit90 gitcommit90 commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Result\n\nRetained Linux hosts now open the health port without synchronously initializing every resident memory database, so real systemd updates stay within their bounded health window. Memory remains initialized for newly created agents and lazily on memory operations.\n\nThis advances the unpublished 0.0.24 candidate to 0.0.25 and retains all Linux/Windows terminal-runtime corrections merged in #33.\n\n## Verification\n\n- npm run typecheck\n- npm run build\n- npm test: 125 native assertions + 110 runnable Node/browser contracts passed; 2 environment-only skips\n- npm run test:onboarding-browser: 20 passed\n- git diff --check

Summary by CodeRabbit

  • New Features
    • Updated the default channel-machine image to version 0.0.25.
  • Bug Fixes
    • Improved server startup so health checks become available without waiting for optional memory setup.
    • Improved lifecycle and failure handling across supported platforms.
  • Documentation
    • Updated the documented package and image versions to 0.0.25.
    • Added release notes and comparison links for version 0.0.25.

Signed-off-by: Joseph Yaksich <gitcommit90@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The release is bumped to 0.0.25, including channel-machine image defaults and documentation. Server bootstrap now prepares durable memory asynchronously so health-port readiness does not wait for optional memory installation.

Changes

Release and runtime updates

Layer / File(s) Summary
Align 0.0.25 image and release references
package.json, src/server/channel-computers.ts, src/server/db.ts, README.md, test/channel-computers.mjs, CHANGELOG.md
Package metadata, image defaults, migration fallbacks, documentation, changelog links, and pinned image tests now reference release 0.0.25.
Make memory preparation asynchronous
src/server/index.ts, test/desktop.mjs
Bootstrap removes per-channel ensureAgentMemory prewarming and handles memoryRuntime with fire-and-forget rejection handling; desktop tests verify health readiness no longer waits for optional memory installation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant bootstrap
  participant memoryRuntime
  participant HTTPServer
  bootstrap->>memoryRuntime: Start durable-memory preparation
  bootstrap->>HTTPServer: Open health port
  memoryRuntime-->>bootstrap: Resolve or reject asynchronously
  bootstrap->>bootstrap: Handle preparation errors
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required template sections like Summary, Type of change, Release notes, and the numbered acceptance ledger. Add the repository template sections with a clear summary, change type, release notes, numbered acceptance items, and the required checklists.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: keeping Linux startup updates within the health-port deadline.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/linux-update-startup-health

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Around line 767-768: Remove the stale [0.0.24] compare-link entry from the
changelog, or update it to reference a valid published tag; keep the existing
[Unreleased] and [0.0.25] links unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b6ec0c31-0699-4da0-a026-5218429bdfda

📥 Commits

Reviewing files that changed from the base of the PR and between 0e7c66d and b47614b.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (8)
  • CHANGELOG.md
  • README.md
  • package.json
  • src/server/channel-computers.ts
  • src/server/db.ts
  • src/server/index.ts
  • test/channel-computers.mjs
  • test/desktop.mjs

Comment thread CHANGELOG.md
Comment on lines +767 to +768
[Unreleased]: https://github.com/gitcommit90/1Helm/compare/v0.0.25...HEAD
[0.0.25]: https://github.com/gitcommit90/1Helm/compare/v0.0.23...v0.0.25

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Remove the stale 0.0.24 compare link.

The release notes state that 0.0.24 was never tagged or published, but [0.0.24] still points to that nonexistent tag on Line 769. Remove the reference or point it to a valid published target.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CHANGELOG.md` around lines 767 - 768, Remove the stale [0.0.24] compare-link
entry from the changelog, or update it to reference a valid published tag; keep
the existing [Unreleased] and [0.0.25] links unchanged.

@gitcommit90
gitcommit90 merged commit 7f968ca into main Jul 29, 2026
6 checks passed
@gitcommit90
gitcommit90 deleted the fix/linux-update-startup-health branch July 29, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant