release: fill the 0.0.39 offline release fallback digests - #60
Merged
Conversation
The website's offline fallback is served when GitHub's release API is unreachable, and install.sh verifies the digest it returns. Those digests are the digests of the 0.0.39 release commit's own artifacts, so they could not exist in that commit. Until now the placeholder was deliberately not 64 hex characters, so latestLinuxRelease() rejected it and /api/releases/linux/latest answered 503 - an installer was told no release was available rather than handed a digest that could not match what it downloaded. The artifacts now exist and have been verified locally against the values reported by the macOS and Linux build lanes: 1Helm-0.0.39-arm64.dmg de381468… 504,397,451 1Helm-0.0.39-mac-arm64.zip a35ba43a… 301,207,402 1Helm-0.0.39-linux-node.tgz ac54f11c… 401,004,908 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release fallback in ChangesRelease fallback metadata
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The offline release fallback is served when GitHub's release API is unreachable, and
install.shverifies the digest it returns. Those digests are the digests of the 0.0.39 release commit's own artifacts, so they could not exist in that commit — this is the follow-up that fills them in, after which the site is redeployed.Until now the placeholder was deliberately not 64 hex characters, so
latestLinuxRelease()rejected it and/api/releases/linux/latestanswered 503 — failing closed rather than handing an installer a digest that could not match what it downloads.Verified locally against what the build lanes reported:
1Helm-0.0.39-arm64.dmgde381468…fd0b1Helm-0.0.39-mac-arm64.zipa35ba43a…45471Helm-0.0.39-linux-node.tgzac54f11c…b077npm run ci: 122 tests, 120 pass, 0 fail.🤖 Generated with Claude Code
Summary by CodeRabbit