Fix CI failures on Git's master branch
#1994
Closed
+43
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
added a commit
to git-for-windows/git
that referenced
this pull request
Oct 24, 2025
This fixes the CI builds on Git's own `master`, which is broken for over two weeks already, with no signs that anyone might find anything wrong with that situation. I am upstreaming this in gitgitgadget#1994. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
In 5275100 (doc: add some missing technical documents, 2025-10-02), some documents were added to the default set of files to be rendered. Unfortunately, this led to CI failures since Oct 10 (see https://github.com/git/git/actions/runs/18418984731), the eight most recent pushes of Git's `master` as of time of writing. Due to the way Git's automation is set up, it is quite difficult to get to the actual problems, as some known-bogus warnings get suppressed in the check that fails the job, but those warnings are _not_ suppressed in the failed jobs' logs. The actual problems look like this: asciidoc: WARNING: remembering-renames.adoc: line 13: list item index: expected 1 got 0 asciidoc: WARNING: remembering-renames.adoc: line 15: list item index: expected 2 got 1 asciidoc: WARNING: remembering-renames.adoc: line 17: list item index: expected 3 got 2 asciidoc: WARNING: remembering-renames.adoc: line 20: list item index: expected 4 got 3 asciidoc: WARNING: remembering-renames.adoc: line 23: list item index: expected 5 got 4 asciidoc: WARNING: remembering-renames.adoc: line 25: list item index: expected 6 got 5 asciidoc: WARNING: remembering-renames.adoc: line 29: list item index: expected 7 got 6 asciidoc: WARNING: remembering-renames.adoc: line 31: list item index: expected 8 got 7 asciidoc: WARNING: remembering-renames.adoc: line 33: list item index: expected 9 got 8 asciidoc: WARNING: remembering-renames.adoc: line 38: section title out of sequence: expected level 1, got level 2 asciidoc: WARNING: sparse-checkout.adoc: line 17: section title out of sequence: expected level 1, got level 2 asciidoc: WARNING: sparse-checkout.adoc: line 928: list item index: expected 1 got 0 asciidoc: WARNING: sparse-checkout.adoc: line 931: list item index: expected 2 got 1 asciidoc: WARNING: sparse-checkout.adoc: line 951: list item index: expected 3 got 2 asciidoc: WARNING: sparse-checkout.adoc: line 974: list item index: expected 4 got 3 asciidoc: WARNING: sparse-checkout.adoc: line 980: list item index: expected 5 got 4 asciidoc: WARNING: sparse-checkout.adoc: line 1033: list item index: expected 6 got 5 asciidoc: WARNING: sparse-checkout.adoc: line 1049: list item index: expected 7 got 6 The problems fall into two categories. The first one is that there are two lists that start at zero instead of 1, which is unexpected for AsciiDoc. In the same spirit as fef1196 (Renumber list in api-command.txt, 2012-12-15), let's simply renumber those lists. The second category will be addressed in a separate commit. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
In 5275100 (doc: add some missing technical documents, 2025-10-02), some documents were added to the default set of files to be rendered. Unfortunately, this led to CI failures since Oct 10 (see https://github.com/git/git/actions/runs/18418984731), the eight most recent pushes of Git's `master` as of time of writing. In the preceding commit, the numbered lists that started at zero (which AsciiDoc cannot handle) were changed, but there are still the following problems: asciidoctor: WARNING: remembering-renames.adoc: line 38: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 94: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 141: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 142: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 184: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 185: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 257: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 288: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 289: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 290: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 397: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 424: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 485: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 486: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: remembering-renames.adoc: line 487: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 17: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 95: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 258: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 303: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 316: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 545: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 612: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 752: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 824: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 895: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 923: section title out of sequence: expected level 1, got level 2 asciidoctor: WARNING: sparse-checkout.adoc: line 1053: section title out of sequence: expected level 1, got level 2 Let's change the level of the sections to fix those warnings, too. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
fix-ci-failures-on-master
branch
from
5a45c6c to
a1868f6
Compare
Member
Author
|
Seems that my search for I just wish that these fixes had been a pre-requisite for the offending topics to advance to Git's |
git-for-windows-ci
pushed a commit
to git-for-windows/git
that referenced
this pull request
Oct 24, 2025
This fixes the CI builds on Git's own `master`, which is broken for over two weeks already, with no signs that anyone might find anything wrong with that situation. I am upstreaming this in gitgitgadget#1994. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to git-for-windows/git
that referenced
this pull request
Oct 27, 2025
This fixes the CI builds on Git's own `master`, which is broken for over two weeks already, with no signs that anyone might find anything wrong with that situation. I am upstreaming this in gitgitgadget#1994. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
webstech
added a commit
that referenced
this pull request
Nov 5, 2025
…pr-repo-clone CIHelper: avoid using the name `git.git` for the `pr-repo`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like the optics of a
masterbranch that fails to pass its own CI builds.