Skip to content

fix: align grep symbol fields with backend - #347

Merged
jlitola merged 2 commits into
mainfrom
jlitola/align-grep-symbol-fields
Sep 3, 2026
Merged

fix: align grep symbol fields with backend#347
jlitola merged 2 commits into
mainfrom
jlitola/align-grep-symbol-fields

Conversation

@jlitola

@jlitola jlitola commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • align code grep --symbol-field and MCP code_grep.symbol_fields with the deployed PkgSeer grepRepo contract
  • centralize the exact 12 supported fields across validation, help, types, and GraphQL projection
  • remove the underivable code, caller_count, and parent_symbol_ref fields
  • update contract tests, implementation docs, and patch release fragments for githits and @githits/mcp

Verification

  • bun test — 3,815 pass, 0 fail
  • focused grep contract suite — 137 pass, 0 fail
  • bun run typecheck
  • bun run lint
  • bun run format:check
  • bun run build
  • bun run validate:packages
  • bun run plugins:generate && bun run plugins:check
  • bun run smoke:cli — 93 steps passed
  • bun run smoke:mcp — 50 steps passed
  • targeted MCP descriptor agent eval — passed with zero failed calls or isolation violations
  • authenticated live grep verified all 12 fields are accepted; content_hash and parent_path hydrate

Review

  • internal Codex review: clean
  • Claude Opus review: one low test-coverage finding fixed in 6758a98; follow-up clean

Removes underivable grep symbol hydration fields from the shared CLI and MCP contract, tightens service and response types, and adds exact contract coverage.
Add a focused subset-selection assertion so the GraphQL query remains limited to requested symbol fields.
@jlitola jlitola added the fix label Sep 3, 2026
@jlitola
jlitola merged commit d08ca56 into main Sep 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant