This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fix the repository detection and initialization #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assetsGitignore.CreateFile(); | ||
| })) | ||
| .Then(GitClient.Add(filesForInitialCommit)) | ||
| .Then(GitClient.Commit("Initial commit", null)) |
Contributor
There was a problem hiding this comment.
Did you try GitClient.AddAndCommit? I was going to log an issue for it because it gave us some trouble previously.
Contributor
There was a problem hiding this comment.
I'll throw up an issue for it
StanleyGoldman
suggested changes
Jun 27, 2017
| } | ||
| } | ||
|
|
||
| [Location("views/branches.yaml", LocationAttribute.Location.UserFolder)] |
Contributor
There was a problem hiding this comment.
This path looks incorrect
Member
Author
There was a problem hiding this comment.
Yeah, that's from my test branch. We're not using this yet, I'll need to pull in the rest of the branch view changes for this one, and then the path needs to be in the project (and we need some .gitignore action for this stuff)
StanleyGoldman
suggested changes
Jun 27, 2017
| Environment.GitExecutablePath = gitSetup.GitExecutablePath; | ||
| else | ||
| Environment.GitExecutablePath = await LookForGitInstallationPath(); | ||
| Logger.Trace("RestartRepository"); |
Contributor
There was a problem hiding this comment.
Update trace message
StanleyGoldman
approved these changes
Jun 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things have been horribly broken in this area since the task rewrite. This hopefully fixes most of it and also caches data so we don't keep redetecting the repository every time we reload.
The UI is still thinking it's not initialized for a few seconds when Unity is loading, a fix for that will come separately.