Iterate over paged data sets#72
Merged
mattpass merged 1 commit intogithub-tools:masterfrom Oct 23, 2013
Merged
Conversation
Some APIs do not honor the per_page API (at least for large values) and require that we actually walk the links headers to pull all data.
Collaborator
|
Sorry for the delay in replying here, I'm slowly ploughing thru issues/PR's to give Michael a hand. This is a great PR, many thanks. However,
Can you confirm/thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some APIs do not honor the per_page API (at least for large values) and
require that we actually walk the links headers to pull all data.
In particular this was seen on the orgRepos call with approximately
125 repos. Only 100 were returned without iteration.