Skip to content

Auto paging#82

Merged
mattpass merged 2 commits intogithub-tools:masterfrom
raphink:dev/auto-paging
Oct 23, 2013
Merged

Auto paging#82
mattpass merged 2 commits intogithub-tools:masterfrom
raphink:dev/auto-paging

Conversation

@raphink
Copy link
Copy Markdown
Contributor

@raphink raphink commented Oct 22, 2013

This is a merge of pull request #72 with HEAD. This feature is essential to using your lib when dealing with over 100 elements in responses. The per_page=1000 argument you pass in the lib is ignored, as Github limits pagination to 100 elements (see http://developer.github.com/v3/#pagination).

kpdecker and others added 2 commits August 27, 2013 17:05
Some APIs do not honor the per_page API (at least for large values) and
require that we actually walk the links headers to pull all data.
@tiagonoronha
Copy link
Copy Markdown

Just wanted to say thanks, I was having the same issue with an organisation with more than 100 repos. Cheers!

mattpass added a commit that referenced this pull request Oct 23, 2013
@mattpass mattpass merged commit 6d5f502 into github-tools:master Oct 23, 2013
@mattpass
Copy link
Copy Markdown
Collaborator

Mmmm, your commit didn't seem to work for me, but someone else merging the same works fine. Maybe some new API call vs legacy commit thing.

Anyway, ended up being pulled in - many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants