Update octokit to 0.16.0 #101
Conversation
There was a problem hiding this comment.
So this isn't needed any more?
There was a problem hiding this comment.
It's deprecated and ignored due to redirect work, says the comment coming from this commit: octokit/octokit.net@3acdd10. The code analysis bails on deprecation warnings, so I took all the calls out.
I have not tested everything, so we might want to hold on merging this for now.
There was a problem hiding this comment.
This is a side-effect of the repository redirects from the API, and because AllowAutoRedirect doesn't set the Authorization header citation when redirecting, it would break for most of our scenarios.
The Authorization header is cleared on auto-redirects and HttpWebRequest automatically tries to re-authenticate to the redirected location. In practice, this means that an application can't put custom authentication information into the Authorization header if it is possible to encounter redirection.
We're now handling the redirects in Octokit and setting the right authorization headers. See octokit/octokit.net#808 for the whole backstory.
|
We're good to go on this one, redirects are handled internally in HttpClient in a proper fashion so we don't have to worry about that 🍍 |
|
✨ |
Let's not merge this one quite yet, it's not needed for the next release.