This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Only use Visual Studio Telemetry on VS 2017 and above #2424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub for Visual Studio is currently broken on Visual Studio 2015, so I'd like this get this PR out ASAP!
Make sure that
Microsoft.VisualStudio.Telemetryis only used on Visual Studio 2017 and above.What this PR does
VisualStudioUsageTracker, an implementation ofIUsageTrackerthat uses VS TelemetryUsageTrackerto use VS TelemetryReviewers
The aim of this PR was to factor out
VisualStudioUsageTrackerwhich can be selectively disabled in Visual Studio 2015. If we deprecate the GitHub telemetry in a future version, we can simply replaceUsageTrackerwithVisualStudioUsageTracker. I've deliberately touchedUsageTrackeras little as possible because it's complex and I don't want to break anything!I've tested this on Visual Studio 2015, 2017 and 2019 using the steps below.
How to test
Repro
2.10.6from the Visual Studio Marketplace and RestartTeam Explorer - ConnectManage Connections > Connect to GitHubGitHubtab (ifGitHub Enterpriseis selected)Sign in with your browserGitHubtab (ifGitHub Enterpriseis selected)Fix
GitHub.VisualStudio.vsixfrom this PRhttps://ci.appveyor.com/project/github-windows/visualstudio/builds/27765286/artifacts
Team Explorer - ConnectManage Connections > Connect to GitHubGitHubtab (ifGitHub Enterpriseis selected)Sign in with your browserConnect to GitHubdialog to closeFixes #2423