This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Port build system to Azure Pipelines #2442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build GHfVS and Essentials extension
This key is for identity not security.
Signed an unsigned assemblies can behave differently. It's important that they're consistently signed when testing.
Users can set this up once and won't need to modify the ApiClientConfiguration_User.cs file in their working directory.
Ensure that build will pick up changes to GitHubVS_ClientId.
Remove dependency on private script submodule
Use a matrix build strategy.
Create the VSIX directly in the ArtifactStagingDirectory.
The default is off.
Handle versioning using Nerdbank.GitVersioning
Sign the VSIX
jcansdale
force-pushed
the
fixes/2039-port-build-to-azure-pipelines
branch
from
be79993 to
738fc03
Compare
jcansdale
force-pushed
the
fixes/2039-port-build-to-azure-pipelines
branch
from
b14dc04 to
c5f0261
Compare
ghost
approved these changes
Nov 12, 2019
|
@jcansdale Can you remove the AppVeyor checks while you're at it? |
Collaborator
Author
I'm hoping that when changes hit |
Collaborator
Author
|
I've disabled the AppVeyor webhook and given it a bump. Seems to be working now. 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate build system from AppVeyer to Azure Pipelines.
What this PR does
https://github.com/VsIDEVersionControl/GitHubIntegration/issues/5
Every build will create artifacts suitable for installing locally and for inserting into the VS installer:
Getting started
Prerequisites
.NET desktop developmentworkloadVisual Studio extension developmentworkload.NET Core cross platform developmentworkloadHow to build
GitHubVS_ClientIDwith yourClient IDGitHubVS_ClientSecretwith yourClient Secretb75a2e63c6c5f06d224210d9d2257608f5d228c9build.cmdGitHub Essentials
Here be dragons
Unfortunately there's a bug in the experimental VSIX functionality (when installed from VS or with
IsExperimental=true):https://devdiv.visualstudio.com/DevDiv/_workitems/edit/994859
This means that packages and assemblies from the experimental and original VSIX can be loaded at the same time (causing confusing and hard to track down errors). To avoid this, you can do the following:
...Common7\IDE\Extensions\GitHub\GitHub.16\GitHub.VisualStudio.16.pkgdefto.pkgdef_(this avoids a duplicate binding path in EXP instance)Testing the extension
You can now start building and installing GitHub Essentials using
src\GitHub.VisualStudio.16.sln.Be sure to test GitHub Essentials on its own and with GitHub for Visual Studio installed.
GitHub for Visual Studio installs for all users, which can make installing/uninstalling a pain. You can install for the current user (or just in the EXP instance) using the following extension:
https://github.com/jcansdale/DogfoodVsix
Fixes #2039