[WIP] Pull Requests: Logged out view

[shana]

When the user is logged out, we should probably not try to show all the data, and instead inform them that they should log in. This PR (initially) contains a stub of a logged out view, to flesh out. To see it, log out of GitHub and make sure you have a GitHub repo selected.

[shana]

@donokuda I rebased this branch against feature/pr/views and enabled the logged out view. This is what I get now:

We might want to dock it to the top so it doesn't appear floating in the middle of the pane, perhaps?

Since this is our UI and not Team Explorer, how about calling it "Login to GitHub" instead of "Connect to GitHub"? "Connect" is a Team Explorer thing which is specific to what it does in TFS (connecting to remote TFS projects).

Also, do we want to have more information on why the user should login? Would that be worth it?

@pmn @haacked Thoughts?

[shana]

On a side note, it is possible to have the login happen directly in the pane and not as a separate dialog, if we want to do that at some point. Just fyi.

[shana]

Should we always set the padding on the container control, so all views get it automatically? Right now we are setting it in each view (like in https://github.com/github/VisualStudio/blob/feature/pr/views/src/GitHub.VisualStudio/UI/Views/PullRequestListView.xaml#L83).

EDIT: nevermind, sometimes we want to extend lines all the way to the edge. So this view needs some padding 😄

[donokuda]

Updated the logged out view (note: the panel title's color currently doesn't change when switching themes and probably should be fixed in a separate branch)

• Moved content to top
• Added margin around the content
• Synced terminology with what we have on GitHub.com (Login vs. Sign in)

Also, do we want to have more information on why the user should login? Would that be worth it?

👍 I copy-pasta'd the text from the Team Explorer but I definitely think the text should be clarified. We could iterate with what we have with something like "Get powerful collaboration, code review, and code management tools for..."

On a side note, it is possible to have the login happen directly in the pane and not as a separate dialog, if we want to do that at some point. Just fyi.

I've thought about this but figured we could use what's already implemented in the extension. However, this might be worth visiting down the road.

[shana]

/cc @haacked @pmn for 👀 the copy and the style

[pmn]

It looks great to me -- ❤️ both the copy and the style.

[haacked]

👍

[shana]

This needs localization, but let's do a full localization pass on the side for the pr branch.