Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented Nov 8, 2016

  • Show just the repository to clone (with a logo) - this is ugly and needs a @donokuda pass.
  • Re-enable detection of existing repository in said clone dialog.

To display only the name of the repository being cloned and the target
path.
@shana
Copy link
Contributor

shana commented Nov 8, 2016

Looks good! Can we get a screenshot of how it looks currently?

@donokuda this branch won't build on 2015 but the xaml designer should be able to load the view. If not, just a mockup will do, we can fix it up ourselves. This is basically the clone dialog, only without the repository list and filter textbox, and instead just showing the name of the repository we're going to clone. Since the size of the window is pretty much fixed (because it has to accommodate the login dialog before), we have a lot of empty space that we need filling.

We should probably have:

  • The avatar that owns the account
  • The name of the account
  • The name of the repository
  • The url to it (just to be clear and you know gotta fill that space)
  • repo/lock/fork icons maybe?

Since this includes a fix to actually make it work properly, we should probably merge this and do the polish on another PR targeting release/2.1.0. @grokys thoughts?

@grokys
Copy link
Contributor Author

grokys commented Nov 8, 2016

This is how it looks currently in all its monochrome glory:

image

@donokuda
Copy link
Contributor

donokuda commented Nov 8, 2016

@shana @grokys Can you walk me through how a user gets to this screen?
Does this replace the existing clone from GitHub flow or is this something like a confirmation screen?

@shana
Copy link
Contributor

shana commented Nov 8, 2016

@donokuda In VS15 Preview 5 there's a new API in the Start Page for cloning repositories that you have already cloned in some other machine - it synchronizes the roaming profile information, which includes information on what you've cloned before (only what you've cloned from the Start Page, right now). So this is the same clone dialog that we have, only we already know exactly what repository we want to clone, and we just need the user to set the path to clone to.

Users will get to this dialog by clicking on the url of a repository in the Start Page, which pops up our dialog, optionally goes through login if needed, then shows this UI with the information about the repository they selected and where they want to clone it to.

@shana shana merged commit 7be63b0 into release/2.1.0 Nov 9, 2016
@shana shana deleted the grokys/start-page-clone branch November 9, 2016 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants