Skip to content

chore(deps): Bump guidepup/setup-action from 0.20.0 to 0.21.0 in the github-actions group across 1 directory - #70

Merged
abdulahmad307 merged 9 commits into
mainfrom
dependabot/github_actions/github-actions-c3a913a9d2
Aug 7, 2026
Merged

chore(deps): Bump guidepup/setup-action from 0.20.0 to 0.21.0 in the github-actions group across 1 directory#70
abdulahmad307 merged 9 commits into
mainfrom
dependabot/github_actions/github-actions-c3a913a9d2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 4, 2026

Copy link
Copy Markdown
Contributor

Bumps the github-actions group with 1 update in the / directory: guidepup/setup-action.

Updates guidepup/setup-action from 0.20.0 to 0.21.0

Release notes

Sourced from guidepup/setup-action's releases.

0.21.0

What's Changed

  • feat!: BREAKING update NVDA version

NVDA has been updated to NVDA 2026.1.1, see https://github.com/nvaccess/nvda/releases/tag/release-2026.1.1

This version of @guidepup/setup is incompatible with @guidepup/guidepup versions less than 0.28.0.

Full Changelog: guidepup/setup-action@0.20.0...0.21.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the github-actions group with 1 update in the / directory: [guidepup/setup-action](https://github.com/guidepup/setup-action).


Updates `guidepup/setup-action` from 0.20.0 to 0.21.0
- [Release notes](https://github.com/guidepup/setup-action/releases)
- [Commits](guidepup/setup-action@5ab89fb...5d19b11)

---
updated-dependencies:
- dependency-name: guidepup/setup-action
  dependency-version: 0.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 4, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner August 4, 2026 06:13
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 4, 2026
@dependabot
dependabot Bot requested a review from sam-smolenski August 4, 2026 06:13
Copilot AI and others added 2 commits August 7, 2026 15:46
Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>
Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>
@abdulahmad307

Copy link
Copy Markdown
Contributor

@copilot i dont think we want a try/catch on whether nvda is present or not. instead, we want to ensure that nvda is present somehow. please look into how we can make that happen.

Copilot AI and others added 2 commits August 7, 2026 17:51
Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>
Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>

Copilot AI commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@copilot i dont think we want a try/catch on whether nvda is present or not. instead, we want to ensure that nvda is present somehow. please look into how we can make that happen.

Updated in commit 7cd22f2. I removed the test-side NVDA presence fallback and changed Windows CI to enforce setup instead: guidepup/setup-action now installs NVDA into a deterministic path (C:\nvda) and the workflow explicitly verifies nvda.exe exists before running npm run test:guidepup.

@abdulahmad307

Copy link
Copy Markdown
Contributor

@copilot the changes you made are causing the following error, please fix:

Exception: D:\a_temp\fdce7930-fb06-4d7a-bb32-92d60bc97e80.ps1:4
Line |
4 | throw "NVDA executable not found at $nvdaExecutablePath"
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| NVDA executable not found at C:\nvda\nvda.exe
Error: Process completed with exit code 1.

@abdulahmad307

Copy link
Copy Markdown
Contributor

@copilot the changes you made are causing the following error, please fix:

Exception: D:\a_temp\fdce7930-fb06-4d7a-bb32-92d60bc97e80.ps1:4
Line |
4 | throw "NVDA executable not found at $nvdaExecutablePath"
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| NVDA executable not found at C:\nvda\nvda.exe
Error: Process completed with exit code 1.

@abdulahmad307

Copy link
Copy Markdown
Contributor

@copilot the change you made is causing an error. please see the output for the error and fix

…path

Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>

Copilot AI commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@copilot the change you made is causing an error. please see the output for the error and fix

Fixed in 1af6fc2.

The check was wrong, not the setup: @guidepup/setup extracts NVDA to <installDir>\nvda-<version>\nvda\, not to <installDir> directly, so C:\nvda\nvda.exe never existed. It then records that directory in HKCU\Software\Guidepup\Nvda under a guidepup_nvda_<version> value, which is exactly what @guidepup/guidepup reads at test time to find nvda.exe.

So I dropped the nvdaInstallDir override (the action's default temp dir is fine) and the verification step now reads that registry entry and asserts nvda.exe exists in one of the registered directories before running npm run test:guidepup.

@abdulahmad307

Copy link
Copy Markdown
Contributor

@copilot can you instead update dependabot to stop trying to update guidepup/setup-action to new versions because its not compatible with guidepup

Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>

Copilot AI commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@copilot can you instead update dependabot to stop trying to update guidepup/setup-action to new versions because its not compatible with guidepup

Done in 1e64e4f.

Added an ignore entry for guidepup/setup-action under the github-actions ecosystem in .github/dependabot.yml, with a comment explaining it's pinned due to @guidepup/guidepup incompatibility and must be bumped manually.

I also reverted the bump itself and the NVDA verification step, so .github/workflows/test.yml is now identical to main (action back at 5ab89fb / 0.20.0) and this PR only contains the Dependabot config change.

@abdulahmad307
abdulahmad307 merged commit 15d720f into main Aug 7, 2026
11 of 13 checks passed
@abdulahmad307
abdulahmad307 deleted the dependabot/github_actions/github-actions-c3a913a9d2 branch August 7, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants