fix: strip npm warn/notice lines from Vally PR comment output - #2455
Merged
Conversation
npm install warnings (EBADENGINE, deprecated) were leaking into both the Summary findings table and the full linter output block, making the comment noisy. Filter them out when processing raw vally output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4c3ca9da-500e-464e-88d3-4c09535ec45c
Contributor
There was a problem hiding this comment.
Pull request overview
Filters npm installation noise from Vally lint PR comments.
Changes:
- Removes
npm warnandnpm noticelines after ANSI cleanup. - Applies filtering before summary counts and full-output rendering.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/skill-check-comment.yml |
Filters npm noise from processed Vally output. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm warnandnpm noticemessages fromnpx's package installation were leaking into the Vally lint PR comment. They appeared in both the Summary findings table (labelled asℹ️advisories) and in the full linter output block.Example noise:
Seen in: #2427 (comment)
Fix
Filter out lines matching
^npm (warn|notice)when processing the raw vally output in the comment script. This cleans up both the summary table and the<details>full output block without affecting any real vally findings.