Merged
Conversation
Member
Author
|
/cc @tmm1 |
Member
Author
|
On a side note, I plan to raise a new PR today which limits the number of hookshot logs we backup which will resolve the severe delay 11.10.3xx users will see when migrating. This will be in line with the number of logs GitHub Enterprise 2.2 retains. |
Member
Author
|
Looking into this further and we've never backed up the hookshot logs on 11.10.3xx instances so hookshot logs won't be affecting migrations from 11.10.34x to 2.x. |
|
/fyi @github/platform |
|
👍 to reverting this. |
Member
Author
|
Thanks @mcolyer. Merging. |
lildude
added a commit
that referenced
this pull request
Aug 6, 2015
…tore Revert "Remove hookshot backup/restore"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #134
Following discussions regarding keeping a backup of the hookshot logs, it has been decided to revert this change as the number of logs will be significantly fewer on later releases of GitHub Enterprise.
This does however reintroduce the severe delay when migrating from GitHub Enterprise 11.10.3xx to 2.x as GitHub Enterprise 11.10.3xx doesn't prune the log files like 2.2 does.