Conversation
koddsson
reviewed
Jan 25, 2021
| } | ||
| } | ||
| }) | ||
| observer.observe(el, {childList: true, subtree: true, attributes: true, attributeFilter: ['data-action']}) |
Contributor
There was a problem hiding this comment.
If either options’s attributeOldValue or attributeFilter is present and options’s attributes is omitted, then set options’s attributes to true.
koddsson
reviewed
Jan 25, 2021
| .attachShadow({ | ||
| mode: template.getAttribute('data-shadowroot') === 'closed' ? 'closed' : 'open' | ||
| }) | ||
| .appendChild(template.content.cloneNode(true)) |
Contributor
There was a problem hiding this comment.
- ParentNode.append() allows you to also append DOMString objects, whereas Node.appendChild() only accepts Node objects.
- ParentNode.append() has no return value, whereas Node.appendChild() returns the appended Node object.
- ParentNode.append() can append several nodes and strings, whereas Node.appendChild() can only append one node.
https://developer.mozilla.org/en-US/docs/Web/API/ParentNode/append
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst looking over some of the code I noticed a couple of spots that could be tightened up. This only reduces the compiled code by 7 bytes gzipped (I know, big deal right?) but the code remains functionally identical and I think it's also a slight readability improvement.