docs: add "things to remember" in lifecycle callbacks#118
Merged
Conversation
koddsson
approved these changes
Feb 19, 2021
|
|
||
| #### Things to remember | ||
|
|
||
| The `connectedCallback` is called _as soon as_ the element is attached to a `document`. This _may_ occur _before_ an element has any children appended to it, so you should be careful not expect an element to have children during a `connectedCallback` call. This means avoiding checking any `target`s or using other methods like `querySelector`. Instead use this function to initialize itself and avoid doing initialization work which depend on children existing. |
Contributor
There was a problem hiding this comment.
This feels like a good candidate for a lint rule that we could offer.
keithamus
deleted the
docs-add-things-to-remember-in-lifecycle-callbacks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a couple of notes about the caveats of
connectedCallbackandattributeChangedCallbackwhich developers have noticed while using Catalyst. This should help future users be less likely to hit these problems, or at the very least give us a place to point them to if they get bit by these behaviours.