feat: properly dasherize class names with acronyms#44
Merged
Conversation
muan
reviewed
Jun 22, 2020
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
keithamus
force-pushed
the
feat-properly-dasherize-class-names-with-acronyms
branch
from
0147022 to
606c825
Compare
Contributor
Author
|
Nice catches @muan! I've updated the PR to fix those cases. I think this is good to go now 👍 |
muan
approved these changes
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the dasherizing code such that it will now respect acronyms (that is, contiguous sets of capital letters) as single words, so for example:
CSSStyle->css-style(old:c-s-s-style)XMLHttpRequest->xml-http-request(old:x-m-l-http-request)GEmoji->g-emoji(old:g-emoji, this is still a respected pattern)ClipX->clip-x(old:clip-x, this is still a respected pattern)While this would technically be a breaking change, we're still Pre 1.0 so this is acceptable to release as a feature, IMO.