Merged
Conversation
Based on user feedback this section has been re-written for a few reasons: - It focusses more on the `@controller` decorator and less on Custom Elements - It repeats (multiple times, including a call-out box) that the class name must consist of two words, as this is something users miss.
muan
reviewed
Jun 25, 2020
Co-authored-by: Mu-An 慕安 <me@muanchiou.com>
koddsson
approved these changes
Jul 14, 2020
Contributor
koddsson
left a comment
koddsson
left a comment
There was a problem hiding this comment.
This is great!
It repeats (multiple times, including a call-out box) that the class name must consist of two words, as this is something users miss.
Maybe we can create a lint rule in github/github and if we end up with a handful of them, we could open source those when we open source this lib?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on user feedback this section has been re-written for a few reasons:
@controllerdecorator and less on Custom Elements