-
Notifications
You must be signed in to change notification settings - Fork 158
Open
Labels
Description
Currently CodeQL permits writing classes with predicates using database queries, and then subclasses which do not fulfill the requirements for these database types. This renders these inherited predicates unusable and creates pretty cryptic compilation errors when trying to use them. Examples:
- Java: Modifier.getLocation() does not work codeql#3705
- Java: Deprecate and remove Element::getDoc codeql#5320
- Java:
Array.getPackage()(andArray.getQualifiedName()) cannot be used codeql#7067
It would be good if:
- The CodeQL compiler would detect such unusuable inherited predicates and cause a compilation error (or at least a warning) for the subclass. This would avoid exposing such subclasses to the user, causing the cryptic compilation errors when they try to use predicates of the subclass.
- The error message would be clearer, ideally pointing to where the requirement for the database types come from, with predicate call hierarchy if possible. For example for CodeQL Java's
Array.getQualifiedName()(see Java:Array.getPackage()(andArray.getQualifiedName()) cannot be used codeql#7067) it should indicate thatRefType.getPackage()only supports@classand@interface.