This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Clean up EmailInjection.qll and related libraries.
#127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
reviewed
May 5, 2020
Contributor
sauyon
left a comment
sauyon
left a comment
There was a problem hiding this comment.
Two minor comments, otherwise LGTM.
| override DataFlow::Node getData() { result = this.getArgument([1, 3, 4]) } | ||
| } | ||
| /** Gets the package name `github.com/sendgrid/sendgrid-go/helpers/mail`. */ | ||
| bindingset[result] |
Contributor
There was a problem hiding this comment.
Should this be removed, or should the body be changed to use the package versioning predicate?
Contributor
Author
There was a problem hiding this comment.
Why do you think it should be removed? It's essentially just a symbolic constant because the string is used twice.
Contributor
There was a problem hiding this comment.
I was specifically talking about the bindingset, I should have been more clear.
Or is there something about the annotation I don't understand?
Contributor
Author
There was a problem hiding this comment.
Ah, you're absolutely right about that. The bindingset is spurious. Let me remove it.
Co-authored-by: Sauyon Lee <sauyon@github.com>
max-schaefer
force-pushed
the
clean-up-email-injection
branch
from
8d06957 to
54f1015
Compare
sauyon
approved these changes
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #108
cc @porcupineyhairs