This repository was archived by the owner on Jan 5, 2023. It is now read-only.
More cleanup #153
Merged
More cleanup #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
reviewed
May 22, 2020
Contributor
sauyon
left a comment
sauyon
left a comment
There was a problem hiding this comment.
A few comments and a question.
ql/src/go.qll
Outdated
| import semmle.go.frameworks.NoSQL | ||
| import semmle.go.frameworks.SystemCommandExecutors | ||
| import semmle.go.frameworks.SQL | ||
| import semmle.go.frameworks.XPath |
Contributor
There was a problem hiding this comment.
Should we realphabetize this in this PR?
| } | ||
|
|
||
| func (_ *Context) IsWebsocket() bool { | ||
| func (_ *Context) IsWebSocket() bool { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (_ *Context) IsWebSocket() bool { | |
| func (_ *Context) IsWebsocket() bool { |
I assume this change was unintended?
Contributor
Author
There was a problem hiding this comment.
Whoops, yes; let me revert those changes.
| type Socket struct { | ||
| Conn interface{} | ||
| WebsocketDialer interface{} | ||
| WebSocketDialer interface{} |
Contributor
There was a problem hiding this comment.
Suggested change
| WebSocketDialer interface{} | |
| WebsocketDialer interface{} |
ditto
| type Socket struct { | ||
| Conn interface{} | ||
| WebsocketDialer interface{} | ||
| WebSocketDialer interface{} |
Contributor
There was a problem hiding this comment.
Suggested change
| WebSocketDialer interface{} | |
| WebsocketDialer interface{} |
| * refer to `"github.com/go-pg/pg/types"`, but also to `"github.com/go-pg/pg/v10/types"`. | ||
| */ | ||
| bindingset[result, mod, path] | ||
| string package(string mod, string path) { |
Contributor
There was a problem hiding this comment.
A thought for the future: should we add a version parameter to match the version as well?
Contributor
Author
There was a problem hiding this comment.
Could do, in the future.
added 5 commits
May 22, 2020 11:11
The predicate now works with an empty package path. The way this is implemented is perhaps slightly non-obvious: the `($|/)\\Q" + path + "\\E"` part of the regular expression either matches the end of the string (and `path` must then be empty), or a slash followed by `path` (which may or may not be empty). We do allow non-canonical import paths ending in `/`, which the compiler rejects. We could disallow that by putting a `(?!$)` assertion after the `/`, but that seems overkill.
Contributor
Author
|
Thanks, @sauyon, comments addressed. |
Contributor
Author
|
Added one more (unrelated) fix. |
sauyon
approved these changes
May 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly related to the WebSocket model introduced in #107 and refined in #109.
Renaming the QLL file from
Websocket.qlltoWebSocket.qllis technically a breaking change, but we only just introduced it, so I think it's fine. (And also one wouldn't normally import that module directly anyway.)