Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Consider Request.FormValue(...) as a source for URL redirects.#162

Merged
max-schaefer merged 1 commit intogithub:masterfrom
max-schaefer:open-url-redirect-formvalue
May 29, 2020
Merged

Consider Request.FormValue(...) as a source for URL redirects.#162
max-schaefer merged 1 commit intogithub:masterfrom
max-schaefer:open-url-redirect-formvalue

Conversation

@max-schaefer
Copy link
Copy Markdown
Contributor

Despite its name, this method doesn't just handle form values but also query parameters.

Fixes https://github.com/github/codeql-go-team/issues/108.

Despite its name, this method doesn't just handle form values but also query parameters.
@max-schaefer max-schaefer requested a review from a team May 29, 2020 14:04
Copy link
Copy Markdown
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should really have remembered this.

@max-schaefer max-schaefer merged commit 2f7ff6b into github:master May 29, 2020
@max-schaefer max-schaefer deleted the open-url-redirect-formvalue branch August 28, 2020 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants