This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Add a superclass for literals#172
Merged
max-schaefer merged 2 commits intogithub:masterfrom Jun 11, 2020
Merged
Conversation
owen-mc
force-pushed
the
superclass-for-literals
branch
from
acbbbd6 to
cd9f243
Compare
sauyon
reviewed
Jun 11, 2020
|
|
||
| @bitwiseexpr = @bitwiseunaryexpr | @bitwisebinaryexpr; | ||
|
|
||
| @literal = @basiclit | @funclit | @compositelit; |
Contributor
There was a problem hiding this comment.
You should make these changes in extractor/dbscheme/tables.go or they won't persist as the make script overwrites this file. Also, I think this change requires a (trivial) database upgrade script; I think there's a wiki page describing it on the old Semmle wiki, do you have access to that?
Contributor
Author
There was a problem hiding this comment.
I've realised it's better to try to do it without changing the database scheme at all
owen-mc
force-pushed
the
superclass-for-literals
branch
from
cd9f243 to
9f271dd
Compare
max-schaefer
previously approved these changes
Jun 11, 2020
Contributor
max-schaefer
left a comment
max-schaefer
left a comment
There was a problem hiding this comment.
LGTM; will merge after class-reference changes are backported.
Co-authored-by: Max Schaefer <54907921+max-schaefer@users.noreply.github.com>
max-schaefer
approved these changes
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.