This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Make the gofmt CI test actually fatal#254
Merged
max-schaefer merged 1 commit intogithub:masterfrom Jul 10, 2020
Merged
Conversation
max-schaefer
suggested changes
Jul 10, 2020
Contributor
max-schaefer
left a comment
max-schaefer
left a comment
There was a problem hiding this comment.
Thanks for catching that. Not as pretty, but if it works that's OK.
Since the clever logic for using environment variables to control whether formatting is only checked or actually enforced no longer works, could you just remove those variables?
Turns out gofmt doesn't actually return 1 when it finds problems, only when it finds source files which don't compile (all of which are now excluded). This also fixes existing overlooked inconsistencies as a result of this mistake.
smowton
force-pushed
the
smowton/admin/fix-go-autoformat
branch
from
2dce532 to
d05657d
Compare
Contributor
Author
|
@max-schaefer done |
max-schaefer
approved these changes
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out gofmt doesn't actually return 1 when it finds problems, only when it finds source files which don't compile (all of which are now excluded).
This also fixes existing overlooked inconsistencies as a result of this mistake.