This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Use bufio and don't sync FS#47
Merged
max-schaefer merged 1 commit intogithub:masterfrom Mar 6, 2020
Merged
Conversation
Contributor
🎉
?
I don't think so. |
Contributor
Author
|
Dist-compare (internal link) seems clean. It doesn't measure extraction time, right?
Sorry, sample size of 1. |
Contributor
Correct. The Go Differences job, on the other hand, does; I'll set off an experiment.
Thanks for the clarification. |
max-schaefer
approved these changes
Mar 6, 2020
Contributor
max-schaefer
left a comment
max-schaefer
left a comment
There was a problem hiding this comment.
Irrespective of the outcome of my experiment, this seems like a good thing to try.
Contributor
|
@sauyon, could you add a change note for this? I think it's user-visible enough to warrant one. |
Contributor
|
Change note added in #101. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found via profiling that the vast majority of the time taken during extraction was
writesyscalls.This empirically makes things much faster on Kubernetes, n=1:
Before:
1481.40s user 996.60s system 282% cpu 14:36.62 total
After:
606.63s user 12.59s system 338% cpu 3:02.91 total
Was there a reason we were running
Syncbefore? My understanding is that it's not necessary unless we want trap files to be uncorrupted if the system crashes.I've kicked off an evaluation.