This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Add sample DB-related queries #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
approved these changes
Aug 10, 2021
sampart
reviewed
Aug 10, 2021
Contributor
sampart
left a comment
sampart
left a comment
There was a problem hiding this comment.
This looks good to my untrained eye; thank you so much for putting this together. Once it's merged, I'll chat to you about what we should tell users about how to make use of these queries.
Would you be happy to update this PR to also "promote" the existing ql/examples/snippets/deferinloop.ql to be an experimental query? That way, all 3 queries mentioned in the blog post can be used in the same way.
co-authored-by: Sam Partington <sampart@github.com> co-authored-by: Robin Neatherway <rneatherway@github.com>
co-authored-by: Robert <robertbrignull@github.com> co-authored-by: Sam Partington <sampart@github.com>
sauyon
force-pushed
the
add-sample-queries
branch
from
a92a63a to
2e30431
Compare
Contributor
Author
|
I've done so. |
Contributor
|
@sauyon tests failing |
sauyon
force-pushed
the
add-sample-queries
branch
from
1044f53 to
1a0f357
Compare
Contributor
Author
|
Forgot to push the |
sauyon
force-pushed
the
add-sample-queries
branch
from
1a0f357 to
4c5d3ff
Compare
Contributor
|
@sampart this is merged |
sampart
added a commit
that referenced
this pull request
Aug 16, 2021
These are the queries added in #558
sampart
added a commit
that referenced
this pull request
Aug 16, 2021
These are the queries added in #558.
sauyon
pushed a commit
to sauyon/codeql-go
that referenced
this pull request
Aug 17, 2021
These are the queries added in github#558.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very barebones qhelps and tests since these are likely to live in experimental for some time anyway.